fix(polars): remove non-working Binary and Decimal literal inference

Author: cpcloud

ibis/backends/polars/compiler.py

@@ -72,22 +72,26 @@ def _make_duration(value, dtype):
 
 @translate.register(ops.Literal)
 def literal(op):
-    if op.dtype.is_array():
-        value = pl.Series("", op.value)
-        typ = to_polars_type(op.dtype)
+    value = op.value
+    dtype = op.dtype
+
+    if dtype.is_array():
+        value = pl.Series("", value)
+        typ = to_polars_type(dtype)
         return pl.lit(value, dtype=typ).list()
-    elif op.dtype.is_struct():
+    elif dtype.is_struct():
         values = [
-            pl.lit(v, dtype=to_polars_type(op.dtype[k])).alias(k)
-            for k, v in op.value.items()
+            pl.lit(v, dtype=to_polars_type(dtype[k])).alias(k) for k, v in value.items()
         ]
         return pl.struct(values)
-    elif op.dtype.is_interval():
-        return _make_duration(op.value, op.dtype)
-    elif op.dtype.is_null():
-        return pl.lit(op.value)
+    elif dtype.is_interval():
+        return _make_duration(value, dtype)
+    elif dtype.is_null():
+        return pl.lit(value)
+    elif dtype.is_binary():
+        raise NotImplementedError("Binary literals do not work in polars")
     else:
-        typ = to_polars_type(op.dtype)
+        typ = to_polars_type(dtype)
         return pl.lit(op.value, dtype=typ)
 
 

ibis/backends/polars/datatypes.py

@@ -12,7 +12,7 @@
     dt.Null: pl.Null,
     dt.Array: pl.List,
     dt.String: pl.Utf8,
-    dt.Binary: pl.Object,
+    dt.Binary: pl.Binary,
     dt.Date: pl.Date,
     dt.Time: pl.Time,
     dt.Int8: pl.Int8,
@@ -25,7 +25,6 @@
     dt.UInt64: pl.UInt64,
     dt.Float32: pl.Float32,
     dt.Float64: pl.Float64,
-    dt.Decimal: pl.Object,
 }
 
 _to_ibis_dtypes = {v: k for k, v in _to_polars_types.items()}
@@ -34,7 +33,12 @@
 @functools.singledispatch
 def to_polars_type(dtype):
     """Convert ibis dtype to the polars counterpart."""
-    return _to_polars_types[dtype.__class__]  # else return  pl.Object?
+    try:
+        return _to_polars_types[dtype.__class__]  # else return  pl.Object?
+    except KeyError:
+        raise NotImplementedError(
+            f"Translation to polars dtype not implemented for {dtype}"
+        )
 
 
 @to_polars_type.register(dt.Timestamp)