fix(sqlite): interpolate pathlib.Path correctly in attach

Author: cpcloud

ibis/backends/sqlite/__init__.py

@@ -162,22 +162,25 @@ def column_reflect(inspector, table, column_info):
             if type(column_info["type"]) is TIMESTAMP:
                 column_info["type"] = ISODATETIME()
 
-    def attach(
-        self,
-        name: str,
-        path: str | Path,
-    ) -> None:
+    def attach(self, name: str, path: str | Path) -> None:
         """Connect another SQLite database file to the current connection.
 
         Parameters
         ----------
         name
             Database name within SQLite
         path
-            Path to sqlite3 database file
+            Path to sqlite3 database files
+
+        Examples
+        --------
+        >>> con1 = ibis.sqlite.connect("original.db")
+        >>> con2 = ibis.sqlite.connect("new.db")
+        >>> con1.attach("new", "new.db")
+        >>> con1.list_tables(database="new")
         """
         quoted_name = self.con.dialect.identifier_preparer.quote(name)
-        self.raw_sql(f"ATTACH DATABASE {path!r} AS {quoted_name}")
+        self.raw_sql(f"ATTACH DATABASE {str(path)!r} AS {quoted_name}")
 
     def _get_sqla_table(self, name, schema=None, autoload=True):
         return sa.Table(

ibis/backends/sqlite/tests/test_client.py

@@ -1,4 +1,5 @@
 import uuid
+from pathlib import Path
 
 import numpy as np
 import pandas.testing as tm
@@ -44,7 +45,7 @@ def test_list_tables(con):
 def test_attach_file(dbpath):
     client = ibis.sqlite.connect(None)
 
-    client.attach('foo', dbpath)
+    client.attach('foo', Path(dbpath))
     client.attach('bar', dbpath)
 
     foo_tables = client.list_tables(database='foo')