NEXT-31592 - Change admin node version to lts

Author: seggewiss

.github/workflows/01-lint-admin.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Retrieve the cached "node_modules" directory (if present)
         uses: actions/cache@v3

.github/workflows/01-lint-storefront.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Retrieve the cached "node_modules" directory (if present)
         uses: actions/cache@v3

.github/workflows/02-unit.yml

@@ -115,7 +115,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Retrieve the cached "node_modules" directory (if present)
         uses: actions/cache@v3
@@ -161,7 +161,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Retrieve the cached "node_modules" directory (if present)
         uses: actions/cache@v3

.gitlab/stages/10-lint.yml

@@ -226,9 +226,8 @@ NPM CI:
         - JS_APP_DIR: "src/Administration/Resources/app/administration/"
           NODE_IMAGE_TAG:
           - "lts-alpine"
-          - "18-alpine"
+          - "20-alpine"
         - JS_APP_DIR: "src/Storefront/Resources/app/storefront/"
           NODE_IMAGE_TAG:
             - "lts-alpine"
-            - "16-alpine"
-            - "18-alpine"
+            - "20-alpine"

.gitlab/templates/plugin.yml

@@ -194,14 +194,15 @@ default:
 build and validate zip:
     stage: build
     image:
-        name: ghcr.io/friendsofshopware/shopware-cli:0.3.16
+        name: ghcr.io/friendsofshopware/shopware-cli:0.4.0
         entrypoint: [ "/usr/local/bin/entrypoint.sh" ]
     rules:
         - exists:
               - composer.json
     variables:
         SHOPWARE_PROJECT_ROOT: "${CI_PROJECT_DIR}"
         APP_ENV: 'dev'
+        NODE_VERSION: 20
     before_script:
       - *setup_platform_and_plugin_files
     script:

.nvmrc

@@ -1 +1 @@
-lts/hydrogen
+lts/iron

changelog/_unreleased/2023-12-07-change-administration-node-version.md

@@ -0,0 +1,16 @@
+---
+title: Change administration node version
+issue: NEXT-31592
+author: Sebastian Seggewiß
+author_email: [email protected]
+author_github: @seggewiss
+---
+# Administration
+* Changed administration node version from `18 || 19 || 20` to `20`
+___
+# Upgrade Information
+## Administration Node.js version change
+
+To use the administration it's now mandatory that your node version is the current LTS version `20` (`Iron`).
+If you use `devenv` or `nvm`, you just need to update your session as our configuration files are configured to use the correct version.
+Otherwise, you need to update your node installation manually.

devenv.nix

@@ -23,7 +23,7 @@ in {
 
   languages.javascript = {
     enable = lib.mkDefault true;
-    package = lib.mkDefault pkgs.nodejs-18_x;
+    package = lib.mkDefault pkgs.nodejs_20;
   };
 
   languages.php = {

src/Administration/Resources/app/administration/package.json

@@ -201,8 +201,8 @@
     "xml2js": "0.4.23"
   },
   "engines": {
-    "node": "^18.0.0 || ^19.0.0 || ^20.0.0",
-    "npm": "^8.0.0 || ^9.0.0 || ^10.0.0"
+    "node": "^20.0.0",
+    "npm": "^10.0.0"
   },
   "browserslist": [
     "last 2 versions",

src/Administration/Resources/app/administration/src/meta/meta.spec.js

@@ -89,8 +89,8 @@ describe('Administration meta tests', () => {
         expect(typeof packageJson).toBe('object');
         expect(packageJson.hasOwnProperty('engines')).toBe(true);
         expect(packageJson.engines.hasOwnProperty('node')).toBe(true);
-        expect(packageJson.engines.node).toBe('^18.0.0 || ^19.0.0 || ^20.0.0');
+        expect(packageJson.engines.node).toBe('^20.0.0');
         expect(packageJson.engines.hasOwnProperty('npm')).toBe(true);
-        expect(packageJson.engines.npm).toBe('^8.0.0 || ^9.0.0 || ^10.0.0');
+        expect(packageJson.engines.npm).toBe('^10.0.0');
     });
 });