Skip to content

Allow users to explicitly mark keys as not eligible for Garbage Collection #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewnguyen22 opened this issue Apr 16, 2025 · 1 comment

Comments

@andrewnguyen22
Copy link

Is your feature request related to a problem? Please describe

In managed mode, a user may want to mark keys as not eligible for garbage collection.

With the following conditions:

  • KeepNumVersions=MaxInt64
  • DiscardTs > KeyTs
  • deleted or expired key at a higher Ts

A key will be eligible for garbage collection.

Describe the solution you'd like

Expose a method in Entry that allows users in Managed Mode to set a Never Discard bit.

// WithNeverDiscard sets merge bit in entry's metadata. This
// prevents the compactor from marking the key eligible for GC.
func (e *Entry) WithNeverDiscard() *Entry {
	e.meta = bitMergeEntry // this works -- but could use another bit
	return e
}

Describe alternatives you've considered

Allow users to explicitly mark keys eligible for garbage collection when DiscardTs is unset.

Additional context

This is useful when users want to leverage the Multi-Version system of BadgerDB in Managed Mode to maintain multiple versions of keys.

Copy link

linear bot commented Apr 16, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant