fix: metadata options not finding sum metrics due to broad of cache key (#837)

Author: knudtty

.changeset/swift-eyes-perform.md

@@ -0,0 +1,6 @@
+---
+"@hyperdx/common-utils": patch
+"@hyperdx/app": patch
+---
+
+fix: metadata getAllKeyValues query key scoped to table now

packages/app/src/components/MetricNameSelect.tsx

@@ -8,6 +8,7 @@ import {
 import { Select } from '@mantine/core';
 
 import { useGetKeyValues } from '@/hooks/useMetadata';
+import { capitalizeFirstLetter } from '@/utils';
 
 const MAX_METRIC_NAME_OPTIONS = 3000;
 
@@ -128,7 +129,7 @@ export function MetricNameSelect({
     useMetricNames(metricSource);
 
   const options = useMemo(() => {
-    return [
+    const metricsFromQuery = [
       ...(gaugeMetrics?.map(metric => ({
         value: `${metric}${SEPARATOR}gauge`,
         label: `${metric} (Gauge)`,
@@ -142,6 +143,20 @@ export function MetricNameSelect({
         label: `${metric} (Sum)`,
       })) ?? []),
     ];
+    // if saved metric does not exist in the available options, assume it exists
+    // and add it to options
+    if (
+      metricName &&
+      !metricsFromQuery.find(
+        metric => metric.value !== `${metricName}${SEPARATOR}${metricType}`,
+      )
+    ) {
+      metricsFromQuery.push({
+        value: `${metricName}${SEPARATOR}${metricType}`,
+        label: `${metricName} (${capitalizeFirstLetter(metricType)})`,
+      });
+    }
+    return metricsFromQuery;
   }, [gaugeMetrics, histogramMetrics, sumMetrics]);
 
   return (

packages/common-utils/src/metadata.ts

@@ -439,7 +439,7 @@ export class Metadata {
     disableRowLimit?: boolean;
   }) {
     return this.cache.getOrFetch(
-      `${chartConfig.from.databaseName}.${keys.join(',')}.${chartConfig.dateRange.toString()}.${disableRowLimit}.values`,
+      `${chartConfig.from.databaseName}.${chartConfig.from.tableName}.${keys.join(',')}.${chartConfig.dateRange.toString()}.${disableRowLimit}.values`,
       async () => {
         const sql = await renderChartConfig(
           {