Skip to content

Question about flip_flag = True if map_location.startswith('singapore') #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shin-kyoto opened this issue Dec 20, 2024 · 0 comments

Comments

@Shin-kyoto
Copy link

Shin-kyoto commented Dec 20, 2024

Hi! Thank you so much for your great work!

I have one question about flip_flag in vad_nuscenes_converter.py.
Why do you flip steering in left-hand traffic? When given manual driving telemetry data from Singapore and US (Miami), isn't it strange that we multiply steering data by -1 for "left turns" in Singapore but not in the US? Whether it's in Singapore or the US, a "left turn" means the car is turning left , not right.

# flip x axis if in left-hand traffic (singapore)
flip_flag = True if map_location.startswith('singapore') else False
if flip_flag:
steering *= -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant