Skip to content

[Feature request] SpatialMaxPooling in ceil mode #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szagoruyko opened this issue Jul 5, 2015 · 6 comments
Closed

[Feature request] SpatialMaxPooling in ceil mode #5

szagoruyko opened this issue Jul 5, 2015 · 6 comments
Assignees

Comments

@szagoruyko
Copy link
Contributor

Caffe and Torch use different max pooling, caffe does ceil when computing output size and torch does floor. We have a switch in cudnn https://github.com/soumith/cudnn.torch/blob/master/Pooling.lua#L17, floor() and ceil() functions, and ceil max-pooling is here https://github.com/szagoruyko/imagine-nn/blob/master/SpatialMaxPooling.cu, clnn needs the same switch I think

@szagoruyko
Copy link
Contributor Author

torch/cunn#106 has the new kernels with ceil, floor and padding support, I think kernels for clnn max pooling have to be taken from this PR.

@hughperkins
Copy link
Owner

Ok. Not sure if I have time for this in immediate future. Please consider submitting a PR for this.

@hughperkins
Copy link
Owner

Hi Sergey, please confirm whether you would like to implement this yourself, and use assignee to assign it to yourself, or whether you are hoping that I might implement it myself, and provide details on your expectations in terms of api and performance.

@szagoruyko
Copy link
Contributor Author

Hi Hugh, this one is easy, you just copy kernels from the other PR, you can do it faster than me.

@hughperkins
Copy link
Owner

Hi Sergey, thanks. I will take a look :-)

@hughperkins hughperkins self-assigned this Sep 22, 2015
@hughperkins
Copy link
Owner

Hi Sergey, merged across to clnn, in master branch. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants