-
Notifications
You must be signed in to change notification settings - Fork 14
[Feature request] SpatialMaxPooling in ceil mode #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
torch/cunn#106 has the new kernels with ceil, floor and padding support, I think kernels for clnn max pooling have to be taken from this PR. |
Ok. Not sure if I have time for this in immediate future. Please consider submitting a PR for this. |
Hi Sergey, please confirm whether you would like to implement this yourself, and use |
Hi Hugh, this one is easy, you just copy kernels from the other PR, you can do it faster than me. |
Hi Sergey, thanks. I will take a look :-) |
Hi Sergey, merged across to clnn, in |
Caffe and Torch use different max pooling, caffe does ceil when computing output size and torch does floor. We have a switch in cudnn https://github.com/soumith/cudnn.torch/blob/master/Pooling.lua#L17, floor() and ceil() functions, and ceil max-pooling is here https://github.com/szagoruyko/imagine-nn/blob/master/SpatialMaxPooling.cu, clnn needs the same switch I think
The text was updated successfully, but these errors were encountered: