Fix #236 fallback to string type when used unsupported field type. Ref: #235

Author: huacnlee

lib/rails-settings/fields/base.rb

@@ -22,8 +22,10 @@ def saved_value
         return parent.send(:_all_settings)[key] if table_exists?
 
         # Fallback to default value if table was not ready (before migrate)
-        puts "WARNING: table: \"#{parent.table_name}\" does not exist or not database connection, `#{parent.name}.#{key}` fallback to returns the default value."
-        nil        
+        puts(
+          "WARNING: table: \"#{parent.table_name}\" does not exist or not database connection, `#{parent.name}.#{key}` fallback to returns the default value."
+        )
+        nil
       end
 
       def default_value
@@ -62,8 +64,12 @@ def generate(**args)
         private
 
         def fetch_field_class(type)
-          field_class_name = type.to_s.split('_').map(&:capitalize).join('')
-          const_get("::RailsSettings::Fields::#{field_class_name}")
+          field_class_name = type.to_s.split("_").map(&:capitalize).join("")
+          begin
+            const_get("::RailsSettings::Fields::#{field_class_name}")
+          rescue StandardError
+            ::RailsSettings::Fields::String
+          end
         end
       end
     end

test/base_test.rb

@@ -51,13 +51,13 @@ class NewSetting < RailsSettings::Base
   end
 
   test "setting_keys" do
-    assert_equal 16, Setting.keys.size
+    assert_equal 17, Setting.keys.size
     assert_includes(Setting.keys, "host")
     assert_includes(Setting.keys, "readonly_item")
     assert_includes(Setting.keys, "default_tags")
     assert_includes(Setting.keys, "omniauth_google_options")
 
-    assert_equal 13, Setting.editable_keys.size
+    assert_equal 14, Setting.editable_keys.size
     assert_includes(Setting.editable_keys, "host")
     assert_includes(Setting.editable_keys, "default_tags")
 
@@ -365,6 +365,13 @@ class NewSetting < RailsSettings::Base
     assert_equal %w[Ruby Rails GitHub], Setting.default_tags
   end
 
+  test "unsupported type to string" do
+    assert_equal "hello", Setting.fallback_field
+
+    Setting.fallback_field = "bar"
+    assert_equal "bar", Setting.fallback_field
+  end
+
   test "key with complex options" do
     assert_equal %w[foo bar], Setting.key_with_more_options
     field = Setting.get_field(:key_with_more_options)

test/dummy/app/models/setting.rb

@@ -48,4 +48,5 @@ def foo
   end
 
   field :key_with_more_options, type: :array, validates: {presence: true}, default: %w[foo bar], foo: 1, section: :theme
+  field :fallback_field, type: :foo_bar, default: "hello"
 end