Using .createProxy() Errors When Used

[Albert-IV]

From your examples on the Nodejitsu blog, the following code should redirect correctly:

var http      = require('http'),
    httpProxy = require('http-proxy');

var proxy = httpProxy.createProxy();


http.createServer(function(req, res) {
  res.end('hi!');
}).listen(3000);


require('http').createServer(function(req, res) {
  proxy.web(req, res, { target: 'http://127.0.0.1:3000' });
}).listen(8000);

When you hit http://localhost:8000, the proxy process dies with this error:

TypeError: Cannot read property 'length' of undefined

Node v0.10.24, http-proxy v1.0.0

[Albert-IV]

To clarify, the createProxyServer() method works as expected.

var httpProxy = require('http-proxy');

httpProxy.createProxyServer({
  target: 'http://127.0.0.1:3000',
  ws    : true
}).listen(80);

Unfortunately this method doesn't allow you to filter by host.

[yawnt]

thanks for reporting, fixed in [email protected]

[Albert-IV]

Not a problem.

[yawnt]

(for the record, you can use the same methods on .createProxyServer().. it will work in the same way .web and ws .. there's a .createProxy() alone because it's more clean semantically :P)

[Albert-IV]

Right on. I was trying to proxy to different ports depending on the req.headers.host, so from what I understand you have to use the .createProxy over .createProxyServer For example, this will error out:

var httpProxy = require('http-proxy');

var options = {
  'localhost': 'http://127.0.0.1:3000',
  'beta.localhost': 'http://127.0.0.1:3001'
}

var proxy = httpProxy.createProxyServer(function(req, res) {
  proxy.web(req, res, {
    target: options[req.headers.host]
  }, function(e) {
  });
}).listen(80);

However this works:

var httpProxy = require('http-proxy');

var proxy = httpProxy.createProxy();

var options = {
  'localhost': 'http://127.0.0.1:3000',
  'beta.localhost': 'http://127.0.0.1:3001'
}

require('http').createServer(function(req, res) {
  proxy.web(req, res, {
    target: options[req.headers.host]
  }, function(e) {
  });
}).listen(80);