Revert "Add validator to check consistency of resource name used for IamResource (smithy-lang#1819)"

This reverts commit 436942e.

Author: jvschneid

smithy-aws-iam-traits/src/main/java/software/amazon/smithy/aws/iam/traits/IamResourceTraitValidator.java

@@ -1,2 +1 @@
 software.amazon.smithy.aws.iam.traits.ConditionKeysValidator
-software.amazon.smithy.aws.iam.traits.IamResourceTraitValidator

smithy-aws-iam-traits/src/main/resources/META-INF/services/software.amazon.smithy.model.validation.Validator

@@ -65,4 +65,18 @@ public void successfullyLoadsConditionKeys() {
         assertThat(index.getDefinedConditionKeys(service, ShapeId.from("smithy.example#GetResource2")).keySet(),
                    is(empty()));
     }
+
+    @Test
+    public void detectsUnknownConditionKeys() {
+        ValidatedResult<Model> result = Model.assembler()
+                .addImport(getClass().getResource("invalid-condition-keys.smithy"))
+                .discoverModels(getClass().getClassLoader())
+                .assemble();
+
+        assertTrue(result.isBroken());
+        assertThat(result.getValidationEvents(Severity.ERROR).stream()
+                           .map(ValidationEvent::getId)
+                           .collect(Collectors.toSet()),
+                contains("ConditionKeys"));
+    }
 }

smithy-aws-iam-traits/src/test/java/software/amazon/smithy/aws/iam/traits/ConditionKeysIndexTest.java

@@ -2,16 +2,13 @@ $version: "1.0"
 
 namespace smithy.example
 
-use aws.api#arn
-
 @aws.api#service(sdkId: "My")
 service MyService {
     version: "2020-07-02",
     resources: [SuperResource]
 }
 
 @aws.iam#iamResource(name: "super")
-@arn(template: "super/{id1}")
 resource SuperResource {
     identifiers: {
         id1: String,