Split tests into two packages and create new mock cores (#384)

* move UI tests into TCTUTest package

* fix linter issue

* add new packages to baseline

* add test packages

* add basic teleclient mock to allow testing core without tdlib

* add CoreResource

* fix auth tests and CoreResource

* remove ensureAwaitingPhoneNumber

* refactor tests

* remove mocks from core package

* structural changes to debug squot

* add tests-misc package

* add misc package at correct position in directory

* add gitignore and fix .squot file

* re-add files from file in

* add tests-misc to baseline

* add resources method on tdlib testcase

* add message tests

* refactor users tests as a NoTdlibTest

* Code formatting, categorizing and fixing the linter

* add UI package to coverage and adapt other pipelines to new naming and packages

* take some tests out of authTests

* rename screenshot file of testMessageShrinksCorrectly

* Adding Tests for TCUModal and TCUTelegram and TCUAuthentication

* fix linter tests

* fix testTelegramOpensAuthentication

Co-authored-by: Tom Richter <[email protected]>
Co-authored-by: Jannis Berndt <[email protected]>

Author: 3 people

.gitignore

@@ -0,0 +1 @@
+.DS_STORE

.smalltalk.lint.ston

@@ -12,6 +12,6 @@ SmalltalkCISpec {
     'scripts/preLoading.st'
   ],
   #testing : {
-    #classes : [ #TCTLinterTests ]
+    #classes : [ #TCTMLinterTests ]
   }
 }

.smalltalk.release.ston

@@ -10,7 +10,7 @@ SmalltalkCISpec {
     }
   ],
    #testing : {
-    #classes : [ #TCTSarFileGenerator ],
+    #classes : [ #TCTMSarFileGenerator ],
     #defaultTimeout : 60
   }
 }

.smalltalk.ston

@@ -11,10 +11,10 @@ SmalltalkCISpec {
   ],
    #testing : {
     #coverage : {
-      #packages : [ 'TelegramClient-Core.*' ]
+      #packages : [ 'TelegramClient-Core.*', 'TelegramClient-UI.*' ]
     },
     #exclude : {
-      #classes : [ #TCTLinterTests ]
+      #classes : [ #TCTMLinterTests ]
     },
     #defaultTimeout : 60
   }

.squot

@@ -1,6 +1,8 @@
 OrderedDictionary {
 	'packages/TelegramClient-Core.package' : #SquotCypressCodeSerializer,
-	'packages/TelegramClient-Tests.package' : #SquotCypressCodeSerializer,
 	'packages/BaselineOfTelegramClient.package' : #SquotCypressCodeSerializer,
-	'packages/TelegramClient-UI.package' : #SquotCypressCodeSerializer
+	'packages/TelegramClient-UI.package' : #SquotCypressCodeSerializer,
+	'packages/TelegramClientTests-Core.package' : #SquotCypressCodeSerializer,
+	'packages/TelegramClientTests-UI.package' : #SquotCypressCodeSerializer,
+	'packages/TelegramClientTests-Misc.package' : #SquotCypressCodeSerializer
 }

packages/BaselineOfTelegramClient.package/BaselineOfTelegramClient.class/instance/baseline..st

@@ -27,9 +27,13 @@ baseline: spec
 				spec requires: #('libraries')];
 			package: 'TelegramClient-UI' with: [
 				spec requires: #('libraries')];
-			package: 'TelegramClient-Tests' with: [
-				spec requires: #('default' 'SwaLint' 'MorphicTestingFramework')].
+			package: 'TelegramClientTests-Misc' with: [
+				spec requires: #('default' 'SwaLint')];
+			package: 'TelegramClientTests-UI' with: [
+				spec requires: #('default' 'MorphicTestingFramework')];
+			package: 'TelegramClientTests-Core' with: [
+				spec requires: #('default')].
 		spec
 			group: 'libraries' with: #('Animations' 'FFI' 'JSON');
 			group: 'default' with: #('TelegramClient-Core' 'TelegramClient-UI');
-			group: 'tests' with: #('TelegramClient-Tests')].
+			group: 'tests' with: #('TelegramClientTests-Misc' 'TelegramClientTests-UI' 'TelegramClientTests-Core')].

packages/BaselineOfTelegramClient.package/BaselineOfTelegramClient.class/methodProperties.json

@@ -2,5 +2,5 @@
 	"class" : {
 		 },
 	"instance" : {
-		"baseline:" : "JB 5/29/2021 21:19",
+		"baseline:" : "RS 6/6/2021 15:14",
 		"postLoad" : "N.S. 5/14/2020 17:20" } }

packages/TelegramClient-Core.package/TCCAuthHandler.class/instance/handleEvent..st

@@ -3,7 +3,7 @@ handleEvent: anEvent
 
 	self authState: ((anEvent at: 'authorization_state') at: '@type').
 
-	self isAuthStateClosed ifTrue: [self client free].
+	self isAuthStateClosed ifTrue: [self core freeClient].
 	self isAwaitingTDLibParams ifTrue: [self setTDLibParams].
 	self isAwaitingDBEncryptionKey ifTrue: [self setDBEncryptionKey: ''].
 	self isAwaitingPhoneNumber ifTrue: [^ #awaitPhoneNumber].

packages/TelegramClient-Core.package/TCCAuthHandler.class/methodProperties.json

@@ -10,7 +10,7 @@
 		"client" : "per 5/21/2021 16:55",
 		"core" : "per 5/21/2021 16:57",
 		"core:" : "per 5/21/2021 16:57",
-		"handleEvent:" : "per 5/21/2021 16:55",
+		"handleEvent:" : "JB 6/7/2021 11:15",
 		"initialize" : "RS 4/28/2021 18:04",
 		"isAuthStateClosed" : "r.s 7/15/2020 12:17",
 		"isAuthorizationStateReady" : "r.s 7/15/2020 12:17",

packages/TelegramClient-Core.package/TCCCore.class/class/newWithTeleClient..st

@@ -0,0 +1,7 @@
+as yet unclassified
+newWithTeleClient: aTeleClient
+
+	^ self basicNew
+		client: aTeleClient;
+		initialize;
+		yourself

packages/TelegramClient-Core.package/TCCCore.class/instance/freeClient.st

@@ -0,0 +1,4 @@
+accessing
+freeClient
+
+	self client ifNotNil: [self client free].

packages/TelegramClient-Core.package/TCCCore.class/instance/initialize.st

@@ -1,8 +1,8 @@
 initialization
 initialize
 
+	self client ifNil: [self client: TCCTeleClient newForCurrentOS].
 	self
-		client: TCCTeleClient newForCurrentOS;
 		initializeHandlers;
 		chats: TCCChats newWithDefaultSorting;
 		loggedInUserID: 0; 

packages/TelegramClient-Core.package/TCCCore.class/methodProperties.json

@@ -1,6 +1,6 @@
 {
 	"class" : {
-		 },
+		"newWithTeleClient:" : "RS 6/3/2021 12:08" },
 	"instance" : {
 		"authHandler" : "R.S 5/20/2020 16:10",
 		"authHandler:" : "R.S 5/20/2020 16:10",
@@ -12,12 +12,13 @@
 		"checkAuthenticationCode:" : "RS 5/4/2021 18:43",
 		"client" : "R.S 5/20/2020 16:08",
 		"client:" : "js 6/13/2020 19:10",
+		"freeClient" : "JB 6/7/2021 11:14",
 		"getChatHistoryFrom:" : "js 8/1/2020 18:19",
 		"getOwnProfile" : "pk 5/13/2021 09:44",
 		"handleEvent:" : "per 5/26/2021 14:04",
 		"handleMessageEvent:" : "pk 5/19/2021 11:29",
 		"handlePendingEvent:" : "per 5/26/2021 14:03",
-		"initialize" : "pk 5/13/2021 09:33",
+		"initialize" : "RS 6/3/2021 11:54",
 		"initializeHandlers" : "per 5/21/2021 16:55",
 		"isClientAlive" : "js 5/28/2020 17:18",
 		"loggedInUserID" : "rs 7/5/2020 14:48",
@@ -32,6 +33,6 @@
 		"sendPhoneNumber:" : "js 6/13/2020 15:35",
 		"setUserID:" : "per 5/13/2021 08:22",
 		"tryHandleError:" : "pk 5/7/2021 12:23",
-		"update" : "RS 4/28/2021 18:03",
+		"update" : "RS 6/3/2021 12:09",
 		"users" : "RK 5/19/2021 09:56",
 		"users:" : "RK 5/19/2021 09:56" } }

packages/TelegramClient-Core.package/TCCTeleClient.class/instance/free.st

@@ -1,7 +1,7 @@
 library calls
 free
 
-	self specificClient free: self handle.
+	self isAlive ifTrue: [self specificClient free: self handle].
 	self
 		specificClient: nil;
 		handle: nil.

packages/TelegramClient-Core.package/TCCTeleClient.class/instance/initialize..st

@@ -1,4 +1,4 @@
 accessing
 isAlive
 
-	^ self specificClient isNil not
+	^ self specificClient notNil

packages/TelegramClient-Core.package/TCCTeleClient.class/instance/isAlive.st

@@ -5,12 +5,11 @@
 		"newWithClient:" : "js 8/7/2020 22:19" },
 	"instance" : {
 		"execute:" : "js 5/28/2020 17:23",
-		"free" : "js 5/28/2020 17:24",
+		"free" : "JB 6/7/2021 11:21",
 		"handle" : "R.S 5/16/2020 10:39",
 		"handle:" : "R.S 5/18/2020 18:20",
-		"initialize:" : "R.S 5/20/2020 16:10",
-		"isAlive" : "js 5/28/2020 17:23",
-		"receive:" : "js 6/13/2020 19:13",
+		"isAlive" : "JB 6/7/2021 11:19",
+		"receive:" : "RS 6/3/2021 11:40",
 		"send:" : "rs 6/6/2020 16:09",
 		"specificClient" : "js 5/28/2020 17:23",
 		"specificClient:" : "js 5/28/2020 17:23" } }