Skip to content

Commit a72afa7

Browse files
committed
Re-structure existing Navigation tests
In preparation for `<form method="post">`-driven navigations, this commit removes unnecessary `[method]` attributes, and renames `[id]` attributes to communicate the verb to the test cases.
1 parent acb003d commit a72afa7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/tests/fixtures/navigation.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ <h1>Navigation</h1>
3535
<p><a id="same-origin-unannotated-link" href="/src/tests/fixtures/one.html">Same-origin unannotated link</a></p>
3636
<p><form id="same-origin-unannotated-form" method="get" action="/src/tests/fixtures/one.html"><button>Same-origin unannotated form</button></form></p>
3737
<p><a id="same-origin-replace-link" href="/src/tests/fixtures/one.html" data-turbo-action="replace">Same-origin data-turbo-action=replace link</a></p>
38-
<p><form id="same-origin-replace-form" method="get" action="/src/tests/fixtures/one.html" data-turbo-action="replace"><button>Same-origin data-turbo-action=replace form</button></form></p>
39-
<p><form id="same-origin-replace-form-submitter" method="get" action="/src/tests/fixtures/one.html"><button data-turbo-action="replace">Same-origin data-turbo-action=replace form</button></form></p>
38+
<p><form id="same-origin-replace-form-get" action="/src/tests/fixtures/one.html" data-turbo-action="replace"><button>Same-origin data-turbo-action=replace form</button></form></p>
39+
<p><form id="same-origin-replace-form-submitter-get" action="/src/tests/fixtures/one.html"><button data-turbo-action="replace">Same-origin data-turbo-action=replace form</button></form></p>
4040
<p><a id="same-origin-false-link" href="/src/tests/fixtures/one.html" data-turbo="false">Same-origin data-turbo=false link</a></p>
4141
<p data-turbo="false"><a id="same-origin-unannotated-link-inside-false-container" href="/src/tests/fixtures/one.html">Same-origin unannotated link inside data-turbo=false container</a></p>
4242
<p data-turbo="false"><a id="same-origin-true-link-inside-false-container" href="/src/tests/fixtures/one.html" data-turbo="true">Same-origin data-turbo=true link inside data-turbo=false container</a></p>

src/tests/functional/navigation_tests.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ export class NavigationTests extends TurboDriveTestCase {
6363
this.assert.equal(await this.visitAction, "replace")
6464
}
6565

66-
async "test following a same-origin data-turbo-action=replace form[method=GET]"() {
67-
this.clickSelector("#same-origin-replace-form button")
66+
async "test following a same-origin GET form[data-turbo-action=replace]"() {
67+
this.clickSelector("#same-origin-replace-form-get button")
6868
await this.nextBody
6969
this.assert.equal(await this.pathname, "/src/tests/fixtures/one.html")
7070
this.assert.equal(await this.visitAction, "replace")
7171
}
7272

73-
async "test following a same-origin form with button[data-turbo-action=replace]"() {
74-
this.clickSelector("#same-origin-replace-form-submitter button")
73+
async "test following a same-origin GET form button[data-turbo-action=replace]"() {
74+
this.clickSelector("#same-origin-replace-form-submitter-get button")
7575
await this.nextBody
7676
this.assert.equal(await this.pathname, "/src/tests/fixtures/one.html")
7777
this.assert.equal(await this.visitAction, "replace")

0 commit comments

Comments
 (0)