3d preview: only update when needed

Author: carrotIndustries

src/imp/3d/3d_view.cpp

@@ -266,9 +266,6 @@ View3DWindow::View3DWindow(BaseObjectType *cobject, const Glib::RefPtr<Gtk::Buil
     canvas->signal_layers_loading().connect([this](unsigned int i, unsigned int n) {
         layer_loading_i = i;
         layer_loading_n = n;
-        if (i >= n)
-            update_button->set_sensitive(true);
-
         update_loading();
     });
 
@@ -381,12 +378,21 @@ void View3DWindow::add_widget(Gtk::Widget *w)
 
 void View3DWindow::update(bool clear)
 {
+    if (!needs_update)
+        return;
     s_signal_request_update.emit();
     canvas->update(board);
     if (clear)
         canvas->clear_3d_models();
     canvas->load_models_async(pool);
     update_button->set_sensitive(false);
+    needs_update = false;
+}
+
+void View3DWindow::set_needs_update()
+{
+    needs_update = true;
+    update_button->set_sensitive(true);
 }
 
 void View3DWindow::set_highlights(const std::set<UUID> &pkgs)

src/imp/3d/3d_view.hpp

@@ -15,6 +15,7 @@ class View3DWindow : public Gtk::Window, public Changeable {
                  Mode mode, class Canvas3D *ca_custom);
     static View3DWindow *create(const class Board &b, class IPool &p, Mode mode, class Canvas3D *ca_custom = nullptr);
     void update(bool clear = false);
+    void set_needs_update();
     void set_highlights(const std::set<UUID> &pkgs);
     void add_widget(Gtk::Widget *w);
 
@@ -51,6 +52,7 @@ class View3DWindow : public Gtk::Window, public Changeable {
     class Canvas3D *canvas = nullptr;
     const class Board &board;
     class IPool &pool;
+    bool needs_update = true;
     const Mode mode;
     Gtk::Box *main_box = nullptr;
 

src/imp/3d/imp_package_3d.cpp

@@ -136,6 +136,7 @@ void ImpPackage::construct_3d()
     view_3d_window = View3DWindow::create(fake_board, *pool.get(), View3DWindow::Mode::PACKAGE, canvas_3d);
     view_3d_window->signal_request_update().connect(sigc::mem_fun(*this, &ImpPackage::update_fake_board));
     view_3d_window->signal_present_imp().connect([this] { main_window->present(); });
+    core_package.signal_rebuilt().connect([this] { view_3d_window->set_needs_update(); });
 
     auto models_box = Gtk::manage(new Gtk::Box(Gtk::ORIENTATION_VERTICAL));
     {

src/imp/imp_board.cpp

@@ -614,6 +614,7 @@ void ImpBoard::construct()
                 canvas->set_selection({});
         }
     });
+    core_board.signal_rebuilt().connect([this] { view_3d_window->set_needs_update(); });
 
     step_export_window = StepExportWindow::create(main_window, core_board, project_dir);
     step_export_window->signal_changed().connect([this] { core_board.set_needs_save(); });