Skip to content

Commit 662ac17

Browse files
committed
modified mastervalue.cgi/mastervaluechange.cgi to automatically identify HMIP devices and query the HMIP xmlrpc port (2010) instead. This closes #14 and #13.
1 parent f71e2d1 commit 662ac17

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

xmlapi/mastervalue.cgi

+6-4
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,12 @@ foreach devid $devids {
5050

5151
puts -nonewline $values(STDOUT)
5252

53-
if {$deviceType=="HM-CC-VG-1"} {
53+
if {[string first "HM-CC-VG-" $deviceType] >= 0} {
5454
set ausgabe [xmlrpc http://127.0.0.1:9292/groups getParamset [list string $deviceAddress] [list string "MASTER"] ]
55-
} else {
56-
set ausgabe [xmlrpc http://127.0.0.1:2001/ getParamset [list string $deviceAddress] [list string "MASTER"] ]
55+
} elseif {[string first "HMIP-" $deviceType] >= 0} {
56+
set ausgabe [xmlrpc http://127.0.0.1:2010/ getParamset [list string $deviceAddress] [list string "MASTER"] ]
57+
} else {
58+
set ausgabe [xmlrpc http://127.0.0.1:2001/ getParamset [list string $deviceAddress] [list string "MASTER"] ]
5759
}
5860

5961
foreach { bezeichnung wert } $ausgabe {
@@ -67,4 +69,4 @@ foreach devid $devids {
6769
}
6870
puts -nonewline {</device>}
6971
}
70-
puts -nonewline {</mastervalue>}
72+
puts -nonewline {</mastervalue>}

xmlapi/mastervaluechange.cgi

+5-3
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,12 @@ for {set counter 0} {$counter<[llength $rec_devids]} {incr counter} {
5151

5252
puts -nonewline $values(STDOUT)
5353

54-
if {$deviceType=="HM-CC-VG-1"} {
54+
if {[string first "HM-CC-VG-" $deviceType] >= 0} {
5555
set ausgabe [xmlrpc http://127.0.0.1:9292/groups putParamset [list string $deviceAddress] [list string "MASTER"] [list struct $cmd]]
56-
} else {
57-
set ausgabe [xmlrpc http://127.0.0.1:2001/ putParamset [list string $deviceAddress] [list string "MASTER"] [list struct $cmd]]
56+
} elseif {[string first "HMIP-" $deviceType] >= 0} {
57+
set ausgabe [xmlrpc http://127.0.0.1:2010/ putParamset [list string $deviceAddress] [list string "MASTER"] [list struct $cmd]]
58+
} else {
59+
set ausgabe [xmlrpc http://127.0.0.1:2001/ putParamset [list string $deviceAddress] [list string "MASTER"] [list struct $cmd]]
5860
}
5961
puts -nonewline {<mastervalue name='}
6062
puts -nonewline $item

0 commit comments

Comments
 (0)