Skip to content

Motion: postpone scheduled removal of color_mode (currently: 2025.3) #134688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SHxKM opened this issue Jan 4, 2025 · 4 comments
Closed

Motion: postpone scheduled removal of color_mode (currently: 2025.3) #134688

SHxKM opened this issue Jan 4, 2025 · 4 comments

Comments

@SHxKM
Copy link

SHxKM commented Jan 4, 2025

The problem

This is not a bug per se, just a request.

Zigbee2MQTT version 1.42.x still uses color_mode when it defines groups. This rightfully causes the following log to be printed on HA startup:

Deprecated flag `color_mode` used in MQTT JSON light config , the `color_mode` flag is not used anymore and should be removed. Got: {[REDACTED_FOR_BREVITY]}. This will stop working in Home Assistant Core 2025.3

This is an issue with Zigbee2MQTT integration of course, so I opened a ticket in their repo here.

Here's why I'm kindly asking to postpone the removal of color_mode to 2025.6:

With the release of Z2M 2.0.0, the developer of this integration stated already that the 1.x.x branch will not be maintained anymore. Additionally, there are many complaints about the breaking changes in 2.0.0 (justified or not - that's a different topic). Eventually everything will settle down I'm sure, but I don't see myself, or others, upgrading very soon. The removal of color_mode from Z2M shouldn't be a challenge, but I anticipate it will not be ported back to 1.x.x.

Given all this, while I fully recognize HA core shouldn't "bend"/cater itself to a specific integration, it would be great to consider postponing the removal of color_mode a bit more, if only to give us Z2M users some more time.

What version of Home Assistant Core has the issue?

core-2024.12.5

What was the last working version of Home Assistant Core?

core-2024.12.5

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2025

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this issue as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


mqtt documentation
mqtt source
(message by IssueLinks)

@frenck
Copy link
Member

frenck commented Jan 4, 2025

Honestly, this is still a few months out 🤷
I think it is way too early to make a call like that.

../Frenck

@Koenkk
Copy link
Contributor

Koenkk commented Jan 5, 2025

This has already been removed from Z2M a long time ago (Koenkk/zigbee2mqtt#22142), it seems the issue @SHxKM has is specific to his setup. I would propose not to postpone removal.

@SHxKM
Copy link
Author

SHxKM commented Jan 5, 2025

This has already been removed from Z2M a long time ago (Koenkk/zigbee2mqtt#22142), it seems the issue @SHxKM has is specific to his setup. I would propose not to postpone removal.

Hey, thanks for taking a look. Are you sure those were removed for groups as well? I think the publishing for individual devices was handled, but not that of groups (in Z2M).

I'll gladly re-check my setup.

@SHxKM SHxKM closed this as completed Jan 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants