Skip to content

Use strong types for AssistPipelineRunStart and AssistPipelineSttEnd #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimoPtr opened this issue May 20, 2025 · 3 comments
Open

Use strong types for AssistPipelineRunStart and AssistPipelineSttEnd #5341

TimoPtr opened this issue May 20, 2025 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TimoPtr
Copy link
Collaborator

TimoPtr commented May 20, 2025

This two types contains a Map<String, Any?> but we are always expecting a specific field. We should avoid use Any as much as we can and here in this case we can simply create the proper class and replace the type of the fields by these new classes.

@TimoPtr TimoPtr added enhancement New feature or request good first issue Good for newcomers labels May 20, 2025
@smithrashell
Copy link

Hello @TimoPtr,
I’d love to work on this issue if it’s still available. Could you please assign it to me

@TimoPtr
Copy link
Collaborator Author

TimoPtr commented May 20, 2025

Hey @smithrashell, sure you can do it on top of this PR #5279 (comment) or wait for it to be merged.

@smithrashell
Copy link

Thanks, @TimoPtr! I’ll go ahead and base my work on top of PR #5279 as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants