Skip to content

feat(icons): add prime-video-alt #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdcool00 opened this issue Mar 26, 2025 · 2 comments · Fixed by #1050
Closed

feat(icons): add prime-video-alt #1046

jdcool00 opened this issue Mar 26, 2025 · 2 comments · Fixed by #1050
Labels
approved When the icon request satisfies the requirements, this label can be added to create a pull request monochrome-icon

Comments

@jdcool00
Copy link

jdcool00 commented Mar 26, 2025

Icon name

prime-video-alt

Paste light mode icon

Image

Paste dark mode icon

Image

Icon type

SVG

Categories

Streaming

Aliases

No response

Additional information

Just wanted to add alternative icons for Prime Video as the existing icons are not square and it does not load up nicely with my dashboard hope it gets approved 😅

@jdcool00 jdcool00 changed the title feat(icons): add prime-video-alt-light feat(icons): add prime-video-alt Mar 26, 2025
@Meierschlumpf
Copy link
Member

Just FYI the light mode icon is actually dark as it needs to be visible on light mode themes (so mostly white backgrounds)

@Meierschlumpf Meierschlumpf added the approved When the icon request satisfies the requirements, this label can be added to create a pull request label Mar 26, 2025
@Meierschlumpf Meierschlumpf marked this as a duplicate of #1045 Mar 26, 2025
@Meierschlumpf Meierschlumpf added approved When the icon request satisfies the requirements, this label can be added to create a pull request and removed approved When the icon request satisfies the requirements, this label can be added to create a pull request labels Mar 26, 2025
@jdcool00
Copy link
Author

jdcool00 commented Mar 27, 2025

Just FYI the light mode icon is actually dark as it needs to be visible on light mode themes (so mostly white backgrounds)

I used to think the same but when I looked at some of the examples in the repo it confused me coz most of the tag -light is used for icons that would look best in a dark webpage, I am still confused coz you seem to understand the light mode and dark mode icons as I do but that is not how it is represented on the repo

Image

If you could clarify tag -light means it is made for light background (the logo itself has to be dark) sites and tag -dark means it is made for dark mode website (the logo itself has to be light/white )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved When the icon request satisfies the requirements, this label can be added to create a pull request monochrome-icon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants