Skip to content

Commit fd366cd

Browse files
committed
fix coverage analysis bug
Signed-off-by: Jeromy Cannon <[email protected]>
1 parent b7aea1a commit fd366cd

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/zxc-code-analysis.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,14 +214,14 @@ jobs:
214214
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
215215
if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
216216
with:
217-
name: ${{ inputs.e2e-node-local-build-test-coverage-report }}
217+
name: ${{ inputs.e2e-node-local-build-coverage-report }}
218218
path: 'coverage/${{ inputs.e2e-node-local-build-test-subdir }}'
219219

220220
- name: Download E2E Add Coverage Report
221221
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
222222
if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
223223
with:
224-
name: ${{ inputs.e2e-node-add-test-coverage-report }}
224+
name: ${{ inputs.e2e-node-add-coverage-report }}
225225
path: 'coverage/${{ inputs.e2e-node-add-test-subdir }}'
226226

227227
- name: Publish To Codecov

src/core/account_manager.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ export class AccountManager {
623623

624624
// ensure serviceEndpoint.ipAddressV4 value for all nodes in the addressBook is a 4 bytes array instead of string
625625
// See: https://github.com/hashgraph/hedera-protobufs/blob/main/services/basic_types.proto#L1309
626+
// TODO: with v0.53 will mirror node no longer need this and we can remove @hashgraph/proto?
626627
const addressBook = HashgraphProto.proto.NodeAddressBook.decode(addressBookBytes)
627628
const hasAlphaRegEx = /[a-zA-Z]+/
628629
let modified = false

0 commit comments

Comments
 (0)