Skip to content

Commit f85e60b

Browse files
committed
removed namespace based on pr comment
Signed-off-by: Jeromy Cannon <[email protected]>
1 parent 422b766 commit f85e60b

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/commands/node.mjs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ export class NodeCommand extends BaseCommand {
656656
for (const nodeId of ctx.config.nodeIds) {
657657
subTasks.push({
658658
title: `Check proxy for node: ${chalk.yellow(nodeId)}`,
659-
task: async () => await self.checkNetworkNodeProxyUp(ctx.config.namespace, nodeId, localPort++)
659+
task: async () => await self.checkNetworkNodeProxyUp(nodeId, localPort++)
660660
})
661661
}
662662

@@ -688,14 +688,13 @@ export class NodeCommand extends BaseCommand {
688688

689689
/**
690690
* Check if the network node proxy is up, requires close() to be called after
691-
* @param namespace the namespace
692691
* @param nodeId the node id
693692
* @param localPort the local port to forward to
694693
* @param maxAttempts the maximum number of attempts
695694
* @param delay the delay between attempts
696695
* @returns {Promise<boolean>} true if the proxy is up
697696
*/
698-
async checkNetworkNodeProxyUp (namespace, nodeId, localPort, maxAttempts = 10, delay = 5000) {
697+
async checkNetworkNodeProxyUp (nodeId, localPort, maxAttempts = 10, delay = 5000) {
699698
const podArray = await this.k8.getPodsByLabel([`app=haproxy-${nodeId}`, 'fullstack.hedera.com/type=haproxy'])
700699

701700
let attempts = 0

test/e2e/commands/01_node.test.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ describe.each([
102102
expect.assertions(1)
103103

104104
try {
105-
await expect(nodeCmd.checkNetworkNodeProxyUp(namespace, 'node0', 30313)).resolves.toBeTruthy()
105+
await expect(nodeCmd.checkNetworkNodeProxyUp('node0', 30313)).resolves.toBeTruthy()
106106
} catch (e) {
107107
nodeCmd.logger.showUserError(e)
108108
expect(e).toBeNull()

test/e2e/commands/02_account.test.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('AccountCommand', () => {
6464
let localPort = 30399
6565
for (const nodeId of argv[flags.nodeIDs.name].split(',')) {
6666
it(`proxy should be UP: ${nodeId} `, async () => {
67-
await nodeCmd.checkNetworkNodeProxyUp(namespace, nodeId, localPort++)
67+
await nodeCmd.checkNetworkNodeProxyUp(nodeId, localPort++)
6868
}, 30000)
6969
}
7070
})

0 commit comments

Comments
 (0)