fix: node add call triggers no prompt found for local-build-path erro… (#517)

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/commands/flags.mjs

@@ -725,6 +725,17 @@ export const allFlags = [
   valuesFile
 ]
 
+/**
+ * Resets the definition.disablePrompt for all flags
+ */
+export function resetDisabledPrompts () {
+  allFlags.forEach(f => {
+    if (f.definition.disablePrompt) {
+      delete f.definition.disablePrompt
+    }
+  })
+}
+
 export const allFlagsMap = new Map(allFlags.map(f => [f.name, f]))
 
 export const nodeConfigFileFlags = new Map([

src/commands/node.mjs

@@ -1194,7 +1194,8 @@ export class NodeCommand extends BaseCommand {
           // disable the prompts that we don't want to prompt the user for
           prompts.disablePrompts([
             flags.devMode,
-            flags.force
+            flags.force,
+            flags.localBuildPath
           ])
 
           await prompts.execute(task, self.configManager, NodeCommand.REFRESH_FLAGS_LIST)
@@ -1452,6 +1453,7 @@ export class NodeCommand extends BaseCommand {
             flags.endpointType,
             flags.force,
             flags.fstChartVersion,
+            flags.localBuildPath,
             flags.gossipEndpoints,
             flags.grpcEndpoints
           ])

src/commands/prompts.mjs

@@ -20,6 +20,7 @@ import { FullstackTestingError, IllegalArgumentError } from '../core/errors.mjs'
 import { ConfigManager, constants } from '../core/index.mjs'
 import * as flags from './flags.mjs'
 import * as helpers from '../core/helpers.mjs'
+import { resetDisabledPrompts } from './flags.mjs'
 
 async function prompt (type, task, input, defaultValue, promptMessage, emptyCheckMessage, flagName) {
   try {
@@ -531,6 +532,7 @@ export async function execute (task, configManager, flagList = []) {
  * @param {CommandFlag[]} flags list of flags to disable prompts for
  */
 export function disablePrompts (flags) {
+  resetDisabledPrompts()
   for (const flag of flags) {
     if (flag.definition) {
       flag.definition.disablePrompt = true

test/e2e/commands/node-add.test.mjs

@@ -75,7 +75,7 @@ describe('Node add', () => {
       flags.devMode.constName
     ])
     await nodeCmd.accountManager.close()
-  }, 600000)
+  }, 800000)
 
   balanceQueryShouldSucceed(nodeCmd.accountManager, nodeCmd, namespace)