chore(typescript): enable typescript's "noImplicitOverride" and fix all errors (#1829)

Signed-off-by: Zhan Milenkov <[email protected]>

Author: instamenta

src/core/config/remote/components/consensus-node-component.ts

@@ -48,7 +48,7 @@ export class ConsensusNodeComponent
     return new ConsensusNodeComponent(name, cluster, namespace, state, nodeId);
   }
 
-  public validate(): void {
+  public override validate(): void {
     super.validate();
 
     if (!Object.values(ConsensusNodeStates).includes(this.state)) {
@@ -64,7 +64,7 @@ export class ConsensusNodeComponent
     }
   }
 
-  public toObject(): IConsensusNodeComponent {
+  public override toObject(): IConsensusNodeComponent {
     return {
       ...super.toObject(),
       state: this.state,

src/core/config/remote/components/relay-component.ts

@@ -32,7 +32,7 @@ export class RelayComponent extends BaseComponent implements IRelayComponent, To
     return new RelayComponent(name, cluster, namespace, consensusNodeAliases);
   }
 
-  public validate(): void {
+  public override validate(): void {
     super.validate();
 
     for (const alias of this.consensusNodeAliases) {
@@ -42,7 +42,7 @@ export class RelayComponent extends BaseComponent implements IRelayComponent, To
     }
   }
 
-  public toObject(): IRelayComponent {
+  public override toObject(): IRelayComponent {
     return {
       consensusNodeAliases: this.consensusNodeAliases,
       ...super.toObject(),

src/core/errors/solo-error.ts

@@ -12,8 +12,8 @@ export class SoloError extends Error {
    * @param meta additional metadata (if any)
    */
   public constructor(
-    public message: string,
-    public cause: Error | any = {},
+    public override message: string,
+    public override cause: Error | any = {},
     public meta: any = {},
   ) {
     super(message);

src/core/genesis-network-models/genesis-network-node-data-wrapper.ts

@@ -20,7 +20,7 @@ export class GenesisNetworkNodeDataWrapper
   public readonly deleted: boolean = false;
 
   public constructor(
-    public readonly nodeId: number,
+    public override readonly nodeId: number,
     public readonly adminKey: PublicKey,
     public readonly description: string,
   ) {

src/core/genesis-network-models/genesis-network-roster-entry-data-wrapper.ts

@@ -8,7 +8,7 @@ export class GenesisNetworkRosterEntryDataWrapper
   extends GenesisNetworkDataWrapper
   implements GenesisNetworkRosterStructure, ToObject<GenesisNetworkRosterStructure>
 {
-  constructor(public readonly nodeId: NodeId) {
+  public constructor(public override readonly nodeId: NodeId) {
     super(nodeId);
   }
 

src/core/model/solo-service.ts

@@ -9,9 +9,9 @@ import {K8ClientService} from '../../integration/kube/k8-client/resources/servic
 
 export class SoloService extends K8ClientService {
   constructor(
-    public readonly metadata: ObjectMeta,
-    public readonly spec: ServiceSpec,
-    public readonly status?: ServiceStatus,
+    public override readonly metadata: ObjectMeta,
+    public override readonly spec: ServiceSpec,
+    public override readonly status?: ServiceStatus,
     public readonly clusterReference?: ClusterReference,
     public readonly context?: string,
     public readonly deployment?: string,

src/core/process-output.ts

@@ -5,18 +5,18 @@ import {type SoloLogger} from './logging/solo-logger.js';
 
 /** Uses the solo logger to handle process output from Listr2 */
 export class CustomProcessOutput extends ProcessOutput {
-  constructor(private readonly logger: SoloLogger) {
+  public constructor(private readonly logger: SoloLogger) {
     super();
   }
 
-  toStdout(chunk: string, eol = true) {
+  public override toStdout(chunk: string, eol = true) {
     for (const line of chunk.toString().split('\n')) {
       this.logger.debug(line);
     }
     return super.toStdout(chunk, eol);
   }
 
-  toStderr(chunk: string, eol = true) {
+  public override toStderr(chunk: string, eol = true) {
     this.logger.error(chunk.toString());
     return super.toStderr(chunk, eol);
   }

src/data/key/config-key-error.ts

@@ -4,9 +4,9 @@ import {SoloError} from '../../core/errors/solo-error.js';
 
 export class ConfigKeyError extends SoloError {
   public constructor(
-    public readonly message: string,
-    public readonly cause: Error | unknown = {},
-    public readonly meta: unknown = {},
+    public override readonly message: string,
+    public override readonly cause: Error | unknown = {},
+    public override readonly meta: unknown = {},
   ) {
     super(message, cause, meta);
   }

src/data/schema/model/utils/transformation-error.ts

@@ -4,9 +4,9 @@ import {SoloError} from '../../../../core/errors/solo-error.js';
 
 export class TransformationError extends SoloError {
   public constructor(
-    public readonly message: string,
-    public readonly cause: Error | unknown = null,
-    public readonly meta: unknown = {},
+    public override readonly message: string,
+    public override readonly cause: Error | unknown = null,
+    public override readonly meta: unknown = {},
   ) {
     super(message, cause, meta);
     this.name = 'TransformationError';

src/integration/helm/base/api/version/invalid-semantic-version-exception.ts

@@ -7,7 +7,7 @@ export class InvalidSemanticVersionException extends Error {
   /**
    * The cause of this exception.
    */
-  public cause?: Error;
+  public override cause?: Error;
 
   /**
    * Constructs a new instance of an {@link InvalidSemanticVersionException}.

src/integration/helm/helm-configuration-exception.ts

@@ -44,5 +44,5 @@ export class HelmConfigurationException extends Error {
     this.name = 'HelmConfigurationException';
   }
 
-  cause?: Error;
+  override cause?: Error;
 }

src/integration/helm/helm-execution-exception.ts

@@ -137,7 +137,7 @@ export class HelmExecutionException extends Error {
    * Returns a string representation of the exception.
    * @returns A string representation of the exception
    */
-  toString(): string {
+  override toString(): string {
     return `HelmExecutionException{message=${this.message}, exitCode=${this.getExitCode()}, stdOut='${this.getStdOut()}', stdErr='${this.getStdErr()}'}`;
   }
 }

tsconfig.json

@@ -26,7 +26,8 @@
     "forceConsistentCasingInFileNames": true,
     "strict": false, // TODO: set to true (which is default), fix a few issues as often as possible, until we can leave true
     "noImplicitReturns": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "noImplicitOverride": true
   },
   "include": [
     "src",