no using async in a callback

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/core/k8.mjs

@@ -608,44 +608,64 @@ export class K8 {
           async ({ status }) => {
             if (status === 'Failure') {
               self._deleteTempFile(tmpFile)
-              return reject(new FullstackTestingError('Tar command failed with status Failure'))
+              const errorMessage = `tar command failed with status Failure while copying from ${podName}:${srcDir}/${srcFile} to ${destPath}`
+              this.logger.error(errorMessage)
+              return reject(new FullstackTestingError(errorMessage))
             }
             this.logger.debug(`copyFrom.callback(status)=${status}`)
           })
           .then(conn => {
-            conn.on('close', async (code, reason) => {
+            conn.on('close', (code, reason) => {
+              this.logger.debug(`connection closed copying from ${podName}:${srcDir}/${srcFile} to ${destPath}`)
               if (code !== 1000) { // code 1000 is the success code
-                return reject(new FullstackTestingError(`failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} because of error (${code}): ${reason}`))
+                const errorMessage = `failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} because of error (${code}): ${reason}`
+                this.logger.error(errorMessage)
+                return reject(new FullstackTestingError(errorMessage))
               }
 
               outputFileStream.end()
-              outputFileStream.close(async () => {
+              let rejection
+              outputFileStream.close(() => {
                 this.logger.debug(`finished closing writerStream copying from ${podName}:${srcDir}/${srcFile} to ${destPath}`)
 
                 try {
                   // extract the downloaded file
-                  await tar.x({
+                  tar.x({
                     file: tmpFile,
                     cwd: destDir
-                  })
-                  self._deleteTempFile(tmpFile)
+                  }).then(() => {
+                    self._deleteTempFile(tmpFile)
 
-                  const stat = fs.statSync(destPath)
-                  if (stat && stat.size === srcFileSize) {
-                    return resolve(true)
-                  } else {
-                    if (!stat) {
-                      additionalErrorMessageDetail = ', statSync returned no file status for the destination file'
+                    const stat = fs.statSync(destPath)
+                    if (stat && stat.size === srcFileSize) {
+                      this.logger.info(`Finished successfully copying from ${podName}:${srcDir}/${srcFile} to ${destPath}`)
                     } else {
-                      additionalErrorMessageDetail = `, stat.size=${stat.size} != srcFileSize=${srcFileSize}`
+                      rejection = true
+                      if (!stat) {
+                        additionalErrorMessageDetail = ', statSync returned no file status for the destination file'
+                      } else {
+                        additionalErrorMessageDetail = `, stat.size=${stat.size} != srcFileSize=${srcFileSize}`
+                      }
                     }
-                  }
+                  }).catch((err) => {
+                    this.logger.error(`failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to download file completely: ${destPath}${additionalErrorMessageDetail}`, err)
+                    rejection = true
+                  })
                 } catch (e) {
-                  return reject(new FullstackTestingError(`failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to extract file: ${destPath}`, e))
+                  const errorMessage = `failed to complete copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to extract file: ${destPath}`
+                  this.logger.error(errorMessage, e)
+                  rejection = true
+                  throw new FullstackTestingError(errorMessage, e)
                 }
               })
 
-              return reject(new FullstackTestingError(`failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to download file completely: ${destPath}${additionalErrorMessageDetail}`))
+              if (rejection) {
+                const errorMessage = `failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to download file completely: ${destPath}${additionalErrorMessageDetail}`
+                this.logger.error(errorMessage)
+                return reject(new FullstackTestingError(errorMessage))
+              } else {
+                return resolve(true)
+              }
             })
 
             conn.on('error', (e) => {
@@ -656,16 +676,19 @@ export class K8 {
           })
 
         errStream.on('data', (data) => {
-          this.logger.error(`error encountered copying from ${podName}:${srcDir}/${srcFile} to ${destPath}, error: ${data.toString()}`)
-          return reject(new FullstackTestingError(`error encountered copying from ${podName}:${srcDir}/${srcFile} to ${destPath}, error: ${data.toString()}`))
+          const errorMessage = `error encountered copying from ${podName}:${srcDir}/${srcFile} to ${destPath}, error: ${data.toString()}`
+          this.logger.error(errorMessage)
+          return reject(new FullstackTestingError(errorMessage))
         })
 
         outputFileStream.on('close', () => {
           this.logger.debug(`finished copying from ${podName}:${srcDir}/${srcFile} to ${destPath}`)
         })
 
         outputFileStream.on('error', (err) => {
-          return reject(new FullstackTestingError(`writerStream error encountered copying from ${podName}:${srcDir}/${srcFile} to ${destPath}, err: ${err.toString()}`, err))
+          const errorMessage = `writerStream error encountered copying from ${podName}:${srcDir}/${srcFile} to ${destPath}, err: ${err.toString()}`
+          this.logger.error(errorMessage, err)
+          return reject(new FullstackTestingError(errorMessage, err))
         })
 
         outputFileStream.on('end', () => {
@@ -685,8 +708,9 @@ export class K8 {
         })
       })
     } catch (e) {
-      throw new FullstackTestingError(
-        `failed to download file from ${podName}:${containerName} [${srcPath} -> ${destDir}]: ${e.message}`, e)
+      const errorMessage = `failed to download file from ${podName}:${containerName} [${srcPath} -> ${destDir}]: ${e.message}`
+      this.logger.error(errorMessage, e)
+      throw new FullstackTestingError(errorMessage, e)
     }
   }