feat: solo network destroy should update remote-config (#1155)

Signed-off-by: instamenta <[email protected]>

Author: instamenta

src/commands/network.ts

@@ -16,7 +16,7 @@
  */
 import {ListrEnquirerPromptAdapter} from '@listr2/prompt-adapter-enquirer';
 import chalk from 'chalk';
-import {Listr, type ListrTask} from 'listr2';
+import {Listr} from 'listr2';
 import {IllegalArgumentError, MissingArgumentError, SoloError} from '../core/errors.js';
 import {BaseCommand} from './base.js';
 import {Flags as flags} from './flags.js';
@@ -40,6 +40,8 @@ import {EnvoyProxyComponent} from '../core/config/remote/components/envoy_proxy_
 import {HaProxyComponent} from '../core/config/remote/components/ha_proxy_component.js';
 import {v4 as uuidv4} from 'uuid';
 import * as Base64 from 'js-base64';
+import type {SoloListrTask} from '../types/index.js';
+import type {Namespace} from '../core/config/remote/types.js';
 
 export interface NetworkDeployConfigClass {
   applicationEnv: string;
@@ -772,10 +774,15 @@ export class NetworkCommand extends BaseCommand {
                 self.logger.error(message);
                 self.logger.showUser(chalk.red(message));
                 networkDestroySuccess = false;
+
                 if (ctx.config.deletePvcs && ctx.config.deleteSecrets && ctx.config.force) {
                   self.k8.deleteNamespace(ctx.config.namespace);
+                } else {
+                  // If the namespace is not being deleted,
+                  // remove all components data from the remote configuration
+                  self.remoteConfigManager.deleteComponents();
                 }
-              }, constants.NETWORK_DESTROY_WAIT_TIMEOUT * 1000);
+              }, constants.NETWORK_DESTROY_WAIT_TIMEOUT * 1_000);
 
               await self.destroyTask(ctx, task);
 
@@ -794,7 +801,7 @@ export class NetworkCommand extends BaseCommand {
 
     try {
       await tasks.run();
-    } catch (e: Error | any) {
+    } catch (e: Error | unknown) {
       throw new SoloError('Error destroying network', e);
     } finally {
       await lease.release();
@@ -947,7 +954,7 @@ export class NetworkCommand extends BaseCommand {
   }
 
   /** Adds the consensus node, envoy and haproxy components to remote config.  */
-  public addNodesAndProxies(): ListrTask<any, any, any> {
+  public addNodesAndProxies(): SoloListrTask<{config: {namespace: Namespace; nodeAliases: NodeAliases}}> {
     return {
       title: 'Add node and proxies to remote config',
       skip: (): boolean => !this.remoteConfigManager.isLoaded(),

src/core/config/local_config.ts

@@ -169,7 +169,7 @@ export class LocalConfig implements LocalConfigData {
       title: 'Prompt local configuration',
       skip: this.skipPromptTask,
       task: async (_: any, task: SoloListrTaskWrapper<any>): Promise<void> => {
-        if (self.configFileExists) {
+        if (self.configFileExists()) {
           self.configManager.setFlag(flags.userEmailAddress, self.userEmailAddress);
         }
 

src/core/config/remote/remote_config_manager.ts

@@ -221,6 +221,13 @@ export class RemoteConfigManager {
 
   /* ---------- Utilities ---------- */
 
+  /** Empties the component data inside the remote config */
+  public async deleteComponents() {
+    await this.modify(async remoteConfig => {
+      remoteConfig.components = ComponentsDataWrapper.initializeEmpty();
+    });
+  }
+
   public isLoaded(): boolean {
     return !!this.remoteConfig;
   }