remove TODOs

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/commands/node.mjs

@@ -954,7 +954,7 @@ export class NodeCommand extends BaseCommand {
 
               // set up the sub-tasks
               return task.newListr(subTasks, {
-                concurrent: true, // since we download in the container directly, we want this to be in parallel across all nodes
+                concurrent: true,
                 rendererOptions: {
                   collapseSubtasks: false
                 }
@@ -992,14 +992,18 @@ export class NodeCommand extends BaseCommand {
           const config = ctx.config
 
           const subTasks = []
+          const nodeList = []
+          const serviceMap = await self.accountManager.getNodeServiceMap(ctx.config.namespace)
+          for (const serviceObject of serviceMap.values()) {
+            nodeList.push(serviceObject.node)
+          }
           for (const nodeId of config.nodeIds) {
             const podName = config.podNames[nodeId]
             subTasks.push({
               title: `Node: ${chalk.yellow(nodeId)}`,
               task: () =>
-                self.plaformInstaller.taskInstall(podName, config.buildZipFile, config.stagingDir,
-                  ['node0', 'node1', 'node2', 'node3'], // TODO get nodeIds to copy keys from // config.nodeIds,
-                  config.keyFormat, config.force)
+                self.plaformInstaller.taskInstall(podName, config.buildZipFile,
+                  config.stagingDir, nodeList, config.keyFormat, config.force)
             })
           }
 

test/e2e/commands/node.test.mjs

@@ -162,7 +162,6 @@ describe.each([
     it('Node0 refresh should succeed', async () => {
       await expect(nodeCmd.refresh(argv)).resolves.toBeTruthy()
     }, 1200000)
-    // TODO need to test with PVCs
     // TODO will have changes when configMap/secrets are implemented
     it('Balance query and account create should succeed', async () => {
       expect.assertions(3)
@@ -244,7 +243,6 @@ describe.each([
     it('Node0 refresh should succeed', async () => {
       await expect(nodeCmd.refresh(argv)).resolves.toBeTruthy()
     }, 1200000)
-    // TODO need to test with PVCs
     // TODO will have changes when configMap/secrets are implemented
     it('Balance query and account create should succeed', async () => {
       expect.assertions(3)