k8 copyFrom cleanup

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/core/k8.mjs

@@ -343,7 +343,7 @@ export class K8 {
    * @param {string} containerName
    * @param {string} destPath - path inside the container
    * @param {number} [timeout] - timeout in ms
-   * @returns {Promise<{owner: string, size: number, modifiedAt: string, name: string, directory: boolean, group: string}>}
+   * @returns {Promise<{owner: string, size: number, modifiedAt: string, name: string, directory: boolean, group: string}[]>}
    * array of directory entries, custom object
    */
   async listDir (podName, containerName, destPath, timeout = 5000) {
@@ -567,13 +567,11 @@ export class K8 {
       const destPath = path.join(destDir, srcFile)
 
       // download the tar file to a temp location
-      // const tmpFile = `${this._tempFileFor(srcFile)}.tar`
       const tmpFile = this._tempFileFor(srcFile)
 
       const self = this
       return new Promise((resolve, reject) => {
         const execInstance = new k8s.Exec(this.kubeConfig)
-        // const command = ['tar', '-cf', '-', '-C', srcDir, srcFile]
         const command = ['cat', `${srcDir}/${srcFile}`]
         const outputFileStream = fs.createWriteStream(tmpFile)
         const outputPassthroughStream = new stream.PassThrough({ highWaterMark: 10 * 1024 * 1024 })
@@ -637,13 +635,8 @@ export class K8 {
 
                 try {
                   fs.copyFileSync(tmpFile, destPath)
-                  // extract the downloaded file
-                  // tar.x({
-                  //   file: tmpFile,
-                  //   cwd: destDir
-                  // }).then(() => {
-                  // self._deleteTempFile(tmpFile)
-                  this.logger.debug(`tmpFile=${tmpFile}`)
+
+                  self._deleteTempFile(tmpFile)
 
                   const stat = fs.statSync(destPath)
                   let rejection
@@ -665,11 +658,6 @@ export class K8 {
                   } else {
                     return resolve(true)
                   }
-                  // }).catch((err) => {
-                  //   const errorMessage = `failed copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to download file completely: ${destPath}${additionalErrorMessageDetail}`
-                  //   this.logger.error(errorMessage, err)
-                  //   return reject(new FullstackTestingError(errorMessage, err))
-                  // })
                 } catch (e) {
                   const errorMessage = `failed to complete copying from ${podName}:${srcDir}/${srcFile} to ${destPath} to extract file: ${destPath}`
                   this.logger.error(errorMessage, e)