fix: updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer (#82)

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

README.md

@@ -205,7 +205,7 @@ Kubernetes Namespace    : solo
   * If it fails, ensure you have enough resources allocated for Docker and restart.
 
 ```
-$ solo network deploy --fst-chart-version 0.22.0
+$ solo network deploy
 
 ******************************* Solo *********************************************
 Version                 : 0.19.1
@@ -422,7 +422,7 @@ In a separate terminal, you may run `k9s` to view the pod status.
 * Deploy helm chart with Hedera network components
 
 ```
-$ solo network deploy --fst-chart-version 0.22.0
+$ solo network deploy
 
 # output is similar to example-1 
 ```

src/core/account_manager.mjs

@@ -162,15 +162,12 @@ export class AccountManager {
       let localPort = constants.LOCAL_NODE_START_PORT
 
       for (const serviceObject of serviceMap.values()) {
-        if (!this.isLocalhost() && !serviceObject.loadBalancerIp) {
-          throw new Error(
-              `Expected service ${serviceObject.name} to have a loadBalancerIP set for basepath ${this.k8.kubeClient.basePath}`)
-        }
-        const host = this.isLocalhost() ? '127.0.0.1' : serviceObject.loadBalancerIp
+        const usePortForward = !(serviceObject.loadBalancerIp)
+        const host = usePortForward ? '127.0.0.1' : serviceObject.loadBalancerIp
         const port = serviceObject.grpcPort
-        const targetPort = this.isLocalhost() ? localPort : port
+        const targetPort = usePortForward ? localPort : port
 
-        if (this.isLocalhost()) {
+        if (usePortForward) {
           this.portForwards.push(await this.k8.portForward(serviceObject.podName, localPort, port))
         }
 
@@ -190,14 +187,6 @@ export class AccountManager {
     }
   }
 
-  /**
-   * returns true if we detect that we are running against a local Kubernetes cluster
-   * @returns boolean true if we are running against a local Kubernetes cluster, else false
-   */
-  isLocalhost () {
-    return this.k8.kubeClient.basePath.includes('127.0.0.1')
-  }
-
   /**
    * Gets a Map of the Hedera node services and the attributes needed
    * @param namespace the namespace of the fullstack network deployment