Skip to content

Commit 42e1685

Browse files
fix: have update readme run after version calculation in deploy and release (#586)
Signed-off-by: Jeromy Cannon <[email protected]>
1 parent ae1c949 commit 42e1685

File tree

3 files changed

+128
-189
lines changed

3 files changed

+128
-189
lines changed

.github/workflows/flow-deploy-release-artifact.yaml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,9 @@ permissions:
3838
id-token: write
3939

4040
jobs:
41-
update-readme:
42-
name: "Update README.md"
43-
uses: ./.github/workflows/flow-update-readme.yaml
44-
with:
45-
commit-changes: true
46-
secrets:
47-
GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
48-
GH_ACCESS_GPG_KEY: ${{ secrets.GH_ACCESS_GPG_KEY }}
49-
GH_ACCESS_PASSPHRASE: ${{ secrets.GH_ACCESS_PASSPHRASE }}
50-
5141
prepare-release:
5242
name: Release / Prepare
5343
runs-on: solo-linux-medium
54-
needs: update-readme
5544
outputs:
5645
version: ${{ steps.tag.outputs.version }}
5746
steps:
@@ -92,11 +81,23 @@ jobs:
9281
[[ "${{ github.event.inputs.dry-run-enabled }}" == true && ! -f VERSION ]] && echo -n "0.0.0-latest" > VERSION
9382
echo "version=$(cat VERSION | tr -d '[:space:]')" >> ${GITHUB_OUTPUT}
9483
84+
update-readme:
85+
name: "Update README.md"
86+
uses: ./.github/workflows/flow-update-readme.yaml
87+
needs: prepare-release
88+
with:
89+
commit-changes: true
90+
secrets:
91+
GH_ACCESS_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
92+
GH_ACCESS_GPG_KEY: ${{ secrets.GH_ACCESS_GPG_KEY }}
93+
GH_ACCESS_PASSPHRASE: ${{ secrets.GH_ACCESS_PASSPHRASE }}
94+
95+
9596
create-github-release:
9697
name: Github / Release
9798
runs-on: solo-linux-medium
9899
needs:
99-
- prepare-release
100+
- update-readme
100101
steps:
101102
- name: Checkout Code
102103
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

.github/workflows/flow-update-readme.yaml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
export SOLO_INIT_OUTPUT=$( solo init -i node1,node2,node3 -n "${SOLO_NAMESPACE}" -s \
117117
"${SOLO_CLUSTER_SETUP_NAMESPACE}" | tee test.log )
118118
119-
export SOLO_NODE_KEYS_OUTPUT=$( solo node keys --gossip-keys --tls-keys | tee test.log )
119+
export SOLO_NODE_KEY_PEM_OUTPUT=$( solo node keys --gossip-keys --tls-keys | tee test.log )
120120
121121
export SOLO_CLUSTER_SETUP_OUTPUT=$( solo cluster setup | tee test.log )
122122
@@ -130,17 +130,12 @@ jobs:
130130
131131
export SOLO_RELAY_DEPLAY_OUTPUT=$( solo relay deploy -i node1,node2 | tee test.log )
132132
133-
export SOLO_INIT_047_OUTPUT=$( solo init -i node1,node2,node3 -n "${SOLO_NAMESPACE}" \
134-
-s "${SOLO_CLUSTER_SETUP_NAMESPACE}" --key-format pem | tee test.log )
135-
136-
export SOLO_NODE_KEY_PEM_OUTPUT=$( solo node keys --gossip-keys --tls-keys --key-format pem | tee test.log )
137-
138133
export SOLO_RELAY_DEPLOY_OUTPUT=$( solo relay deploy | tee test.log )
139134
echo "Generate README.md"
140135
141-
envsubst '$KIND_CREATE_CLUSTER_OUTPUT,$SOLO_INIT_OUTPUT,$SOLO_NODE_KEYS_OUTPUT, $SOLO_CLUSTER_SETUP_OUTPUT, \
136+
envsubst '$KIND_CREATE_CLUSTER_OUTPUT,$SOLO_INIT_OUTPUT,$SOLO_NODE_KEY_PEM_OUTPUT,$SOLO_CLUSTER_SETUP_OUTPUT, \
142137
$SOLO_NETWORK_DEPLOY_OUTPUT,$SOLO_NODE_SETUP_OUTPUT,$SOLO_NODE_START_OUTPUT,$SOLO_MIRROR_NODE_DEPLOY_OUTPUT,\
143-
$SOLO_RELAY_DEPLAY_OUTPUT,$SOLO_INIT_047_OUTPUT,$SOLO_NODE_KEY_PEM_OUTPUT,$SOLO_RELAY_DEPLOY_OUTPUT'\
138+
$SOLO_RELAY_DEPLAY_OUTPUT,$SOLO_RELAY_DEPLOY_OUTPUT'\
144139
< README.md.template > README.md
145140
146141
echo "Remove color codes and lines showing intermediate progress"

0 commit comments

Comments
 (0)