updated container to use passed in values correctly so we don't need to push the changes through application.env anymore

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/commands/node/tasks.ts

@@ -936,7 +936,7 @@ export class NodeCommandTasks {
         const podName = ctx.config.podNames[nodeAlias];
         subTasks.push({
           title: `Node: ${chalk.yellow(nodeAlias)}`,
-          task: () => this.platformInstaller.taskSetup(podName, nodeAlias, ctx.config.stagingDir, isGenesis),
+          task: () => this.platformInstaller.taskSetup(podName, ctx.config.stagingDir, isGenesis),
         });
       }
 

src/core/platform_installer.ts

@@ -279,24 +279,14 @@ export class PlatformInstaller {
   }
 
   /** Return a list of task to perform node directory setup */
-  taskSetup(podName: PodName, nodeAlias: NodeAlias, stagingDir: string, isGenesis: boolean) {
+  taskSetup(podName: PodName, stagingDir: string, isGenesis: boolean) {
     const self = this;
     return new Listr(
       [
         {
           title: 'Copy configuration files',
           task: async () => await self.copyConfigurationFiles(stagingDir, podName, isGenesis),
         },
-        {
-          title: 'Update with node specific values',
-          task: async () =>
-            await this.k8.execContainer(podName, constants.ROOT_CONTAINER, [
-              'bash',
-              '-c',
-              `echo CONSENSUS_NODE_ID=${Templates.nodeIdFromNodeAlias(nodeAlias)} >> /etc/network-node/application.env;` +
-                ` echo CONSENSUS_NODE_ALIAS=${nodeAlias} >> /etc/network-node/application.env`,
-            ]),
-        },
         {
           title: 'Set file permissions',
           task: async () => await self.setPlatformDirPermissions(podName),