Skip to content

refactor: create new eventEmitter instances in classes instead of passing the same instance #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konstantinabl opened this issue Apr 17, 2025 · 0 comments
Open

refactor: create new eventEmitter instances in classes instead of passing the same instance #3707

konstantinabl opened this issue Apr 17, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@konstantinabl
Copy link
Contributor

Currently, we pass around one instance of the eventEmitter in classes that need it. @acuarica suggested we shouldn't do this, but instead create a new instance in the different classes.

Discussion - > #3646 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konstantinabl