fix: removed re-throw jsonRpcError for processRpcMethod()

Signed-off-by: Logan Nguyen <[email protected]>

Author: quiet-node

packages/relay/src/lib/dispatcher/rpcMethodDispatcher.ts

@@ -134,13 +134,6 @@ export class RpcMethodDispatcher {
     // Execute the operation handler with the rearranged parameters
     const result = await operationHandler(...rearramgedRpcParams);
 
-    // Note: This is a temporary workaround to avoid introducing new logic. However, in follow-up updates,
-    //       all operation handlers should directly throw JSON RPC errors and return only valid results,
-    //       ensuring proper error handling in the centralized handleRpcMethodError component.
-    if (result instanceof JsonRpcError) {
-      throw result;
-    }
-
     return result;
   }
 

packages/relay/tests/lib/dispatcher/rpcMethodDispatcher.spec.ts

@@ -185,16 +185,12 @@ describe('RpcMethodDispatcher', () => {
       expect(operationHandler.calledWith(...TEST_PARAMS_REARRANGED_DEFAULT)).to.be.true;
     });
 
-    it('should throw if handler returns a JsonRpcError', async () => {
+    it('should directly return JsonRpcError if the handler returns a JsonRpcError', async () => {
       const jsonRpcError = new JsonRpcError({ code: -32000, message: 'Handler error' });
       operationHandler.returns(jsonRpcError);
 
-      try {
-        await (dispatcher as any).processRpcMethod(operationHandler, TEST_PARAMS, TEST_REQUEST_DETAILS);
-        expect.fail('Should have thrown an error');
-      } catch (error) {
-        expect(error).to.equal(jsonRpcError);
-      }
+      const result = await (dispatcher as any).processRpcMethod(operationHandler, TEST_PARAMS, TEST_REQUEST_DETAILS);
+      expect(result).to.equal(jsonRpcError);
     });
   });