feat: Support accepting/declining rewards in yahcli DAB transactions #19255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Hess <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #19255 +/- ##
============================================
- Coverage 69.36% 69.35% -0.01%
+ Complexity 23271 23269 -2
============================================
Files 2645 2645
Lines 100710 100710
Branches 10409 10409
============================================
- Hits 69855 69851 -4
- Misses 26891 26895 +4
Partials 3964 3964 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This version of yahcli adds support for defining node rewards behavior in the dynamic address book. For yahcli node create commands, the new
--declineRewardsflag indicates such to the consensus node, while a value of--declineRewards falseindicates the intent to accept rewards. The node update command, keeping with the format of the staking command, now has two additional parameters:--startDecliningRewardsandstopDecliningRewards, where of course 'stop declining rewards' means 'start accepting rewards.'Closes #19247