Skip to content

Commit f56a5fc

Browse files
authored
fix: Allow scheduled transactions to have preceding transactions (#12626)
Signed-off-by: Michael Heinrichs <[email protected]>
1 parent 62ad616 commit f56a5fc

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -589,8 +589,8 @@ public <T> T doDispatchPrecedingTransaction(
589589
requireNonNull(txBody, "txBody must not be null");
590590
requireNonNull(recordBuilderClass, "recordBuilderClass must not be null");
591591

592-
if (category != TransactionCategory.USER && category != TransactionCategory.CHILD) {
593-
throw new IllegalArgumentException("Only user- or child-transactions can dispatch preceding transactions");
592+
if (category == PRECEDING) {
593+
throw new IllegalArgumentException("A preceding transaction cannot dispatch preceding transactions");
594594
}
595595

596596
final var precedingRecordBuilder = recordBuilderFactory.get();

hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/HandleContextImplTest.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1182,7 +1182,9 @@ void testDispatchHandleFails(final Consumer<HandleContext> contextDispatcher) th
11821182
@ParameterizedTest
11831183
@EnumSource(TransactionCategory.class)
11841184
void testDispatchPrecedingWithNonUserTxnFails(final TransactionCategory category) {
1185-
if (category != TransactionCategory.USER && category != TransactionCategory.CHILD) {
1185+
if (category != TransactionCategory.USER
1186+
&& category != TransactionCategory.CHILD
1187+
&& category != TransactionCategory.SCHEDULED) {
11861188
// given
11871189
final var context = createContext(defaultTransactionBody(), category);
11881190

0 commit comments

Comments
 (0)