fix: tokenAssociate throws IndexOutOfBoundsException (#12453)

Signed-off-by: Zhivko Kelchev <[email protected]>
Co-authored-by: Valentin Tronkov <[email protected]>

Author: JivkoKelchev

hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/BaseTokenHandler.java

@@ -173,19 +173,22 @@ protected void createAndLinkTokenRels(
         // Link the new token relations to the account
         linkTokenRels(account, newTokenRels, tokenRelStore);
 
-        // Now replace the account's old head token number with the new head token number. This is
-        // how we link the new tokenRels to the account
-        final var firstOfNewTokenRels = newTokenRels.get(0);
-        final var updatedAcct = account.copyBuilder()
-                // replace the head token number with the first token number of the new tokenRels
-                .headTokenId(firstOfNewTokenRels.tokenId())
-                // and also update the account's total number of token associations
-                .numberAssociations(account.numberAssociations() + newTokenRels.size())
-                .build();
-
-        // Save the results
-        accountStore.put(updatedAcct);
-        newTokenRels.forEach(tokenRelStore::put);
+        // FUTURE - We may need to return a proper error status when tokens are empty
+        if (!newTokenRels.isEmpty()) {
+            // Now replace the account's old head token number with the new head token number. This is
+            // how we link the new tokenRels to the account
+            final var firstOfNewTokenRels = newTokenRels.get(0);
+            final var updatedAcct = account.copyBuilder()
+                    // replace the head token number with the first token number of the new tokenRels
+                    .headTokenId(firstOfNewTokenRels.tokenId())
+                    // and also update the account's total number of token associations
+                    .numberAssociations(account.numberAssociations() + newTokenRels.size())
+                    .build();
+
+            // Save the results
+            accountStore.put(updatedAcct);
+            newTokenRels.forEach(tokenRelStore::put);
+        }
     }
 
     /**

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/precompile/AssociatePrecompileSuite.java

@@ -53,7 +53,6 @@
 import static com.hederahashgraph.api.proto.java.ResponseCodeEnum.CONTRACT_REVERT_EXECUTED;
 import static com.hederahashgraph.api.proto.java.ResponseCodeEnum.INVALID_ACCOUNT_ID;
 import static com.hederahashgraph.api.proto.java.ResponseCodeEnum.INVALID_TOKEN_ID;
-import static com.hederahashgraph.api.proto.java.ResponseCodeEnum.REVERTED_SUCCESS;
 import static com.hederahashgraph.api.proto.java.ResponseCodeEnum.SUCCESS;
 import static com.hederahashgraph.api.proto.java.TokenType.FUNGIBLE_COMMON;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -398,7 +397,9 @@ final HapiSpec associateTokensNegativeScenarios() {
                                         NEGATIVE_ASSOCIATIONS_CONTRACT,
                                         "associateTokensWithEmptyTokensArray",
                                         accountAddress.get())
-                                .hasKnownStatus(CONTRACT_REVERT_EXECUTED)
+                                // match mono behaviour, this is a successful call, but it should not associate any
+                                // tokens
+                                .hasKnownStatus(SUCCESS)
                                 .gas(GAS_TO_OFFER)
                                 .signingWith(ACCOUNT)
                                 .via(nonExistingTokenArray)
@@ -447,9 +448,7 @@ final HapiSpec associateTokensNegativeScenarios() {
                                 CONTRACT_REVERT_EXECUTED,
                                 recordWith().status(INVALID_ACCOUNT_ID)),
                         childRecordsCheck(
-                                nonExistingTokenArray,
-                                CONTRACT_REVERT_EXECUTED,
-                                recordWith().status(REVERTED_SUCCESS)),
+                                nonExistingTokenArray, SUCCESS, recordWith().status(SUCCESS)),
                         childRecordsCheck(
                                 someNonExistingTokenArray, SUCCESS, recordWith().status(SUCCESS)),
                         childRecordsCheck(