chore: Remove Validator concept from Otter Framework

Fix #19261

Signed-off-by: Timo Brandstätter <[email protected]>

Author: timo0

platform-sdk/consensus-otter-tests/src/test/java/org/hiero/otter/test/BirthRoundMigrationTest.java

@@ -71,8 +71,6 @@ void testBirthRoundMigration(TestEnvironment env) throws InterruptedException {
         timeManager.waitFor(THIRTY_SECONDS);
 
         // Validations
-        env.validator().assertPlatformStatus().assertMetrics();
-
         assertThat(network.getLogResults()).noMessageWithLevelHigherThan(WARN);
         assertThat(network.getConsensusResult())
                 .hasAdvancedSince(freezeRound)

platform-sdk/consensus-otter-tests/src/test/java/org/hiero/otter/test/HappyPathTest.java

@@ -15,7 +15,6 @@
 import org.hiero.otter.fixtures.OtterTest;
 import org.hiero.otter.fixtures.TestEnvironment;
 import org.hiero.otter.fixtures.TimeManager;
-import org.hiero.otter.fixtures.Validator.Profile;
 import org.hiero.otter.fixtures.result.MultipleNodeLogResults;
 import org.junit.jupiter.api.Disabled;
 
@@ -36,8 +35,6 @@ void testHappyPath(TestEnvironment env) throws InterruptedException {
         timeManager.waitFor(Duration.ofMinutes(2L));
 
         // Validations
-        env.validator().validateRemaining(Profile.DEFAULT);
-
         final MultipleNodeLogResults logResults =
                 network.getLogResults().ignoring(network.getNodes().getFirst()).ignoring(STARTUP);
         assertThat(logResults).noMessageWithLevelHigherThan(Level.INFO);

platform-sdk/consensus-otter-tests/src/test/java/org/hiero/otter/test/SandboxTest.java

@@ -4,8 +4,6 @@
 import static com.swirlds.logging.legacy.LogMarker.SOCKET_EXCEPTIONS;
 import static com.swirlds.logging.legacy.LogMarker.TESTING_EXCEPTIONS_ACCEPTABLE_RECONNECT;
 import static org.hiero.otter.fixtures.OtterAssertions.assertThat;
-import static org.hiero.otter.fixtures.Validator.EventStreamConfig.ignoreNode;
-import static org.hiero.otter.fixtures.Validator.RatioConfig.within;
 
 import java.time.Duration;
 import java.util.List;
@@ -16,7 +14,6 @@
 import org.hiero.otter.fixtures.OtterTest;
 import org.hiero.otter.fixtures.TestEnvironment;
 import org.hiero.otter.fixtures.TimeManager;
-import org.hiero.otter.fixtures.Validator.Profile;
 import org.junit.jupiter.api.Disabled;
 
 public class SandboxTest {
@@ -53,12 +50,6 @@ void testConsistencyNDReconnect(TestEnvironment env) throws InterruptedException
         timeManager.waitFor(TWO_MINUTES);
 
         // Validations
-        env.validator()
-                .assertStdOut()
-                .eventStream(ignoreNode(node))
-                .reconnectEventStream(node)
-                .validateRemaining(Profile.DEFAULT);
-
         assertThat(network.getLogResults()
                         .ignoring(SOCKET_EXCEPTIONS)
                         .ignoring(TESTING_EXCEPTIONS_ACCEPTABLE_RECONNECT))
@@ -85,11 +76,5 @@ void testBranching(TestEnvironment env) throws InterruptedException {
 
         // Wait for one minute
         timeManager.waitFor(ONE_MINUTE);
-
-        // Validations
-        env.validator()
-                .consensusRatio(within(0.8, 1.0))
-                .staleRatio(within(0.0, 0.1))
-                .validateRemaining(Profile.HASHGRAPH);
     }
 }

platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/TestEnvironment.java

@@ -35,14 +35,6 @@ public interface TestEnvironment {
     @NonNull
     TransactionGenerator generator();
 
-    /**
-     * Get the validator associated with this test environment.
-     *
-     * @return the validator
-     */
-    @NonNull
-    Validator validator();
-
     /**
      * Destroys the test environment. Once this method is called, the test environment and all its
      * components are no longer usable. This method is idempotent, meaning that it is safe to call

platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/Validator.java

@@ -30,9 +30,7 @@
 import org.hiero.otter.fixtures.TestEnvironment;
 import org.hiero.otter.fixtures.TimeManager;
 import org.hiero.otter.fixtures.TransactionGenerator;
-import org.hiero.otter.fixtures.Validator;
 import org.hiero.otter.fixtures.logging.internal.InMemoryAppender;
-import org.hiero.otter.fixtures.validator.ValidatorImpl;
 
 /**
  * A test environment for the Turtle framework.
@@ -180,16 +178,6 @@ public TransactionGenerator generator() {
         return generator;
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    @NonNull
-    public Validator validator() {
-        log.warn("Validator is not implemented yet");
-        return new ValidatorImpl();
-    }
-
     /**
      * {@inheritDoc}
      */