Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing uses-proxyprotocol does not remove the "Proxy protocol" checkmark on Loadbalancer #876

Open
andsens opened this issue Mar 4, 2025 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@andsens
Copy link

andsens commented Mar 4, 2025

TL;DR

When setting the load-balancer.hetzner.cloud/uses-proxyprotocol: "true" annotation on a loadbalancer service, the "Proxy protocol" checkmark is correctly set on a loadbalancer.
However, removing that same annotation does not unset the checkmark. The loadbalancer remains with the proxyprotocol feature enabled.

Expected behavior

The cloud controller should disable the "Proxy protocol" feature, since that is the default, and the annotation is no longer specified.

Observed behavior

The cloud controller leaves the "Proxy protocol" feature enabled.

Minimal working example

No response

Log output


Additional information

No response

@andsens andsens added the bug Something isn't working label Mar 4, 2025
@lukasmetzner
Copy link
Contributor

Hey,

I agree, this should be the expected behavior.

We have discussed this issue internally and came to the conclusion, that this would a breaking change as users might have removed the annotation without setting the configured value back to its default.

Furthermore, I have checked and there are other annotations, for example the algorithm type, which keep the last configured value. To be consistent we should make this the default behavior for all annotations with a default value.

We put this task on our roadmap for a v2.0.0 release of HCCM, but I can't provide a timeframe estimate.

For now, I would ask you to configure the default value manually via the annotation and remove it once the changes have propagated.

Best Regards
Lukas

@lukasmetzner lukasmetzner added this to the v2.0.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants