fix: duplicate usage output (#786)

phm07 · web-flow · commit b4df982dba07 · 2024-06-20T12:45:27.000+02:00
When a `*pflag.FlagSet` is parsed, it outputs a usage string if the `--help` flag is included. Since Cobra already does this, this behavior needs to be disabled or the usage will be printed twice. --- Since #736 hasn't been release yet, this fix shouldn't appear in the changelog. BEGIN_COMMIT_OVERRIDE feat: new configuration system, config subcommand END_COMMIT_OVERRIDE
diff --git a/internal/state/config/config.go b/internal/state/config/config.go
@@ -85,6 +85,7 @@ func (cfg *config) reset() {
 	cfg.v.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))
 
 	cfg.fs = pflag.NewFlagSet("hcloud", pflag.ContinueOnError)
+	cfg.fs.Usage = func() {} // disable usage output
 	for _, o := range Options {
 		o.addToFlagSet(cfg.fs)
 	}

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ func (cfg *config) reset() {`
`85`	`85`	`cfg.v.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))`
`86`	`86`
`87`	`87`	`cfg.fs = pflag.NewFlagSet("hcloud", pflag.ContinueOnError)`
	`88`	`+ cfg.fs.Usage = func() {} // disable usage output`
`88`	`89`	`for _, o := range Options {`
`89`	`90`	`o.addToFlagSet(cfg.fs)`
`90`	`91`	`}`