fix: don't setup worktree if not packaging for git (#486)

Signed-off-by: Chris Wiggins <[email protected]>

Author: chriswiggins

pkg/releaser/releaser.go

@@ -289,11 +289,15 @@ func (r *Releaser) addToIndexFile(indexFile *repo.IndexFile, url string) error {
 
 // CreateReleases finds and uploads Helm chart packages to GitHub
 func (r *Releaser) CreateReleases() error {
-	worktree, err := r.git.AddWorktree("", r.config.Remote+"/"+r.config.PagesBranch)
-	if err != nil {
-		return err
+	worktree := ""
+	if r.config.PackagesWithIndex {
+		worktree, err := r.git.AddWorktree("", r.config.Remote+"/"+r.config.PagesBranch)
+		if err != nil {
+			return err
+		}
+
+		defer r.git.RemoveWorktree("", worktree) // nolint: errcheck
 	}
-	defer r.git.RemoveWorktree("", worktree) // nolint: errcheck
 
 	packages, err := r.getListOfPackages(r.config.PackagePath)
 	if err != nil {

pkg/releaser/releaser_test.go

@@ -467,6 +467,13 @@ func TestReleaser_CreateReleases(t *testing.T) {
 				assert.Equal(t, tt.commit, fakeGitHub.release.Commit)
 				assert.Equal(t, tt.latest, fakeGitHub.release.MakeLatest)
 				assert.Equal(t, tt.Releaser.config.Commit, fakeGitHub.release.Commit)
+				if !tt.Releaser.config.PackagesWithIndex {
+					fakeGit.AssertNumberOfCalls(t, "AddWorktree", 0)
+					fakeGit.AssertNumberOfCalls(t, "RemoveWorktree", 0)
+					fakeGit.AssertNumberOfCalls(t, "Add", 0)
+					fakeGit.AssertNumberOfCalls(t, "Commit", 0)
+					fakeGit.AssertNumberOfCalls(t, "Push", 0)
+				}
 				fakeGitHub.AssertNumberOfCalls(t, "CreateRelease", 1)
 			}
 		})