Add syntax highlighting for new language (WebAssembly TextFormat)

[Jomy10]

Summary

I would like to add WebAssembly TextFormat syntax highlighting to Helix. But I can't get it to work.

Reproduction Steps

I have added the following to languages.toml:

[[language]]
name = "webAssembly"
scope = "source.wat"
injection-regex = "wasm"
file-types = ["wat", "wast"]
roots = []
comment-token = ";;"

[[grammer]]
name = "webAssembly"
source = { git = "https://github.com/wasm-lsp/tree-sitter-wasm" }

I ran hx --health webAssembly and got the following output:

Configured language server: None
Configured debug adapter: None
Highlight queries: ✘
Textobject queries: ✘
Indent queries: ✘

I ran hx --grammar fetch but got no output related to the webAssembly.

I'm not sure what's wrong.

Helix log

~/.cache/helix/helix.log

2022-08-27T18:46:44.679 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2022-08-27T18:49:30.203 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2022-08-27T18:49:53.540 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T18:50:00.601 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:01:19.849 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2022-08-27T19:05:44.283 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2022-08-27T19:06:34.344 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2022-08-27T19:08:58.360 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:20:56.142 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:24:36.958 helix_lsp::transport [ERROR] err: <- StreamClosed
2022-08-27T19:24:36.959 helix_lsp::transport [ERROR] err: <- StreamClosed
2022-08-27T19:24:48.958 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:25:19.321 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:25:55.373 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:27:59.435 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:28:19.498 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:29:07.151 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:30:16.583 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:30:30.406 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:31:20.486 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:31:38.733 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:31:48.884 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:32:11.337 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:32:27.992 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:33:11.115 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:33:53.358 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:37:20.015 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:37:25.570 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:37:35.855 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:37:44.744 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:38:19.017 helix_lsp::transport [ERROR] err: <- StreamClosed
2022-08-27T19:38:35.404 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:38:56.271 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:39:55.648 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:40:27.072 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:42:04.027 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:42:34.373 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:44:29.986 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:47:20.647 helix_view::editor [ERROR] Failed to initialize the LSP for `source.wat` { LSP not defined }
2022-08-27T19:50:55.799 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }

Platform

macOS

Terminal Emulator

iTerm 2

Helix Version

helix 22.05 (27609f5)

[kirawi]

You also need queries. It doesn't look like that repo has any default queries, so you'll have to write them yourself.

[Jomy10]

With the subpath argument, I got it to build now. But when running hx --health wasm it still shows Highlight queries: ✘. I have a file at ~/.config/helix/runtime/queries/wasm/highlights.scm.

:tree-sitter-scopes also returnd [] for me

[the-mikedavis]

Ah, if you installed through brew, brew will be setting the HELIX_RUNTIME var in a way that you can't override it: https://github.com/aslilac/homebrew-core/blob/a987dd7da0252014cea7126056c002b03c5a6728/Formula/helix.rb#L30

So we won't be able to pick up the queries in ~/.config/helix/runtime. We would need #3346 to handle this better. For now you'll need to build from source rather than use brew in order to add custom queries.

[Jomy10]

@the-mikedavis I see, that's unfortunate. I'll see what I'll do later.

P.S. Would wasm be fit to include by default in Helix, or is it only popular languages that get included?

[the-mikedavis]

Wasm would be a nice addition I think, a PR would be most welcome 👍

[Jomy10]

Cool, I'll look into it later, expect a PR request soon.