Skip to content

Commit b671479

Browse files
committed
Fix signature help panic when too large
When signature help is too large it may cause a panic when it is too large, now I just make the hover do an intersection with surface to make sure it never overflow.
1 parent c4aec0a commit b671479

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

helix-term/src/ui/lsp.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,9 @@ impl Component for SignatureHelp {
6868

6969
let (_, sig_text_height) = crate::ui::text::required_size(&sig_text, area.width);
7070
let sig_text_area = area.clip_top(1).with_height(sig_text_height);
71+
let sig_text_area = sig_text_area.inner(&margin).intersection(surface.area);
7172
let sig_text_para = Paragraph::new(sig_text).wrap(Wrap { trim: false });
72-
sig_text_para.render(sig_text_area.inner(&margin), surface);
73+
sig_text_para.render(sig_text_area, surface);
7374

7475
if self.signature_doc.is_none() {
7576
return;

0 commit comments

Comments
 (0)