Skip to content

There is no "uglifycss" filter #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidino opened this issue Oct 30, 2014 · 9 comments
Closed

There is no "uglifycss" filter #77

davidino opened this issue Oct 30, 2014 · 9 comments

Comments

@davidino
Copy link

Hi all,

i'm using this version:

"helios-ag/fm-elfinder-bundle": "2.3.*"

for each deploy, i've these errors:

assetic.ERROR: The template "FMElfinderBundle:Elfinder/compressed:tinymce4.html.twig" contains an error: There is no "uglifycss" filter. [] []
assetic.ERROR: The template "FMElfinderBundle:Elfinder/compressed:simple.html.twig" contains an error: There is no "uglifycss" filter. [] []
assetic.ERROR: The template "FMElfinderBundle:Elfinder/compressed:tinymce.html.twig" contains an error: There is no "uglifycss" filter. [] []
assetic.ERROR: The template "FMElfinderBundle:Elfinder/compressed:ckeditor.html.twig" contains an error: There is no "uglifycss" filter. [] []

Now, it's true, "uglifycss" is not installed in my system, but i've used this configuation:

fm_elfinder:
    instances:
        default:
            compression: false

so, i don't wan't use this filter.

Anyone have this problem ?

Thank you.
@helios-ag
Copy link
Owner

Hi @davidino , we have discussion here: #40 about removing assetic, please share your thoughts.

@tPl0ch
Copy link

tPl0ch commented Nov 26, 2014

@helios-ag Well, since Symfony 2.3 is a long term support version, having this fixed for the 2.3 would be very nice.

@helios-ag
Copy link
Owner

@tPl0ch Ok, i will remove dependency from uglify/assetic.

@truckee
Copy link

truckee commented Dec 2, 2014

@helios-ag Looking forward to seeing dependency removed.

@cve
Copy link

cve commented Dec 4, 2014

+1

@truckee
Copy link

truckee commented Dec 5, 2014

Until this is done I've avoided the error by overriding the offending files in ...app/Resources/FMElfinderBundle/views/Elfinder/compressed and removing references to uglify as in the following excerpt:

before

    <meta charset="utf-8">
        {% stylesheets output='assetic/css/compiled/fmelfinder/main.css'
        'bundles/fmelfinder/css/*' filter='cssrewrite,?uglifycss' %}
            <link rel="stylesheet" href="{{ asset_url }}" />
        {% endstylesheets %}
</head>
<body>
        {% javascripts output='assetic/js/compiled/fmelfinder/main.js' filter='?uglifyjs2'

after

    <meta charset="utf-8">
        {% stylesheets output='assetic/css/compiled/fmelfinder/main.css'
        'bundles/fmelfinder/css/*' filter='cssrewrite' %}
            <link rel="stylesheet" href="{{ asset_url }}" />
        {% endstylesheets %}
</head>
<body>
        {% javascripts output='assetic/js/compiled/fmelfinder/main.js'
            '@FMElfinderBundle/Resources/public/js/jquery/jquery-1.8.0.min.js'

@helios-ag
Copy link
Owner

Removed assetic dep from 2.3 branch in #89

@fmosca
Copy link

fmosca commented Dec 6, 2014

@truckee workaround worked for me, thanks!

@truckee
Copy link

truckee commented Dec 6, 2014

@helios-ag Thanks for removing. Much cleaner now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tPl0ch @davidino @helios-ag @cve @fmosca @truckee