Skip to content

WebClient logging does not always apply String.format() to certain arguments #9787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ljnelson opened this issue Feb 12, 2025 · 0 comments · Fixed by #9797
Closed

WebClient logging does not always apply String.format() to certain arguments #9787

ljnelson opened this issue Feb 12, 2025 · 0 comments · Fixed by #9797
Assignees
@ljnelson
Labels
4.x Version 4.x bug Something isn't working P3 webclient

Comments

@ljnelson
Copy link
Member

https://github.com/helidon-io/helidon/blob/4.1.6/webclient/http1/src/main/java/io/helidon/webclient/http1/Http1ConnectionCache.java#L186-L188

Output ends up being:

Feb 12, 2025 12:57:07 PM io.helidon.webclient.http1.Http1ConnectionCache finishRequest
FINE: [%s] client connection returned %s

There may be other instances of this bug.
@github-project-automation github-project-automation bot moved this to Triage in Backlog Feb 12, 2025
@m0mus m0mus added 4.x Version 4.x webclient bug Something isn't working P3 labels Feb 13, 2025
@m0mus m0mus moved this from Triage to Sprint Scope in Backlog Feb 13, 2025
@ljnelson ljnelson mentioned this issue Feb 13, 2025
Merged
@github-project-automation github-project-automation bot moved this from Sprint Scope to Closed in Backlog Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljnelson ljnelson

Labels
4.x Version 4.x bug Something isn't working P3 webclient
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes apparent omission of String.format calls in Http1ConnectionCache.java ljnelson/helidon
2 participants
@ljnelson @m0mus