Skip to content

4.x Health endpoint lost its no-cache settings from 3.x #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjquinno opened this issue Jan 20, 2025 · 0 comments · Fixed by #9671
Closed

4.x Health endpoint lost its no-cache settings from 3.x #9670

tjquinno opened this issue Jan 20, 2025 · 0 comments · Fixed by #9671
Assignees
Labels
4.x Version 4.x bug Something isn't working health P2
Milestone

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

See #4241

Apparently this fix in 3.x for health was lost in the conversion to observers.

Steps to reproduce

Run a Helidon server (such as the SE or MP QuickStart app) with health support, access the health endpoint, and inspect the returned headers.

< HTTP/1.1 204 No Content
< Date: Mon, 20 Jan 2025 16:53:35 -0600
< Connection: keep-alive
< Content-Length: 0
<

Compare to the headers returned from the metrics endpoint:

< HTTP/1.1 200 OK
< Date: Mon, 20 Jan 2025 16:52:49 -0600
< Cache-Control: no-cache
< Cache-Control: no-store
< Cache-Control: must-revalidate
< Cache-Control: no-transform
< Connection: keep-alive
< Content-Length: 7118
< Content-Type: text/plain
<
@tjquinno tjquinno added 4.x Version 4.x bug Something isn't working health P2 labels Jan 20, 2025
@tjquinno tjquinno added this to the 4.1.7 milestone Jan 20, 2025
@tjquinno tjquinno self-assigned this Jan 20, 2025
@tjquinno tjquinno added this to Backlog Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Triage in Backlog Jan 20, 2025
@tjquinno tjquinno moved this from Triage to Sprint Scope in Backlog Jan 20, 2025
@tjquinno tjquinno mentioned this issue Dec 23, 2024
15 tasks
@github-project-automation github-project-automation bot moved this from Sprint Scope to Closed in Backlog Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working health P2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant