Skip to content

4.x: Error handling closes connection after sending keep-alive #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomas-langer opened this issue Jul 19, 2024 · 0 comments · Fixed by #9014
Closed

4.x: Error handling closes connection after sending keep-alive #9013

tomas-langer opened this issue Jul 19, 2024 · 0 comments · Fixed by #9014
Assignees
@tomas-langer
Labels
4.x Version 4.x bug Something isn't working webserver
Milestone
4.0.11

Comments

@tomas-langer
Copy link
Member

tomas-langer commented Jul 19, 2024 •
edited
Loading

There are two problems:

  1. When an Error is thrown from user code, it is not caught by ErrorHandlers, so user error handlers for such an Error are ignored
  2. This error would then be caught by connection handler, which returns an internal server error with Connection: keep-alive, but it immediately closes the connection (which is not great for the client)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-langer tomas-langer

Labels
4.x Version 4.x bug Something isn't working webserver
Projects
Backlog
Archived in project
Milestone
4.0.11
1 participant
@tomas-langer