Skip to content

Commit 57378d8

Browse files
authored
Fixes apparent omission of String.format calls in Http1ConnectionCache.java (#9797)
Signed-off-by: Laird Nelson <[email protected]>
1 parent f55b804 commit 57378d8

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

webclient/http1/src/main/java/io/helidon/webclient/http1/Http1ConnectionCache.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -188,24 +188,24 @@ private boolean finishRequest(LinkedBlockingDeque<TcpClientConnection> connectio
188188
if (connectionQueue.offer(conn, QUEUE_TIMEOUT.toMillis(), TimeUnit.MILLISECONDS)) {
189189
conn.helidonSocket().idle(); // mark it as idle to stay blocked at read for closed conn detection
190190
if (LOGGER.isLoggable(DEBUG)) {
191-
LOGGER.log(DEBUG, "[%s] client connection returned %s",
192-
conn.channelId(),
193-
Thread.currentThread().getName());
191+
LOGGER.log(DEBUG, String.format("[%s] client connection returned %s",
192+
conn.channelId(),
193+
Thread.currentThread().getName()));
194194
}
195195
return true;
196196
} else {
197197
if (LOGGER.isLoggable(DEBUG)) {
198-
LOGGER.log(DEBUG, "[%s] Unable to return client connection because queue is full %s",
199-
conn.channelId(),
200-
Thread.currentThread().getName());
198+
LOGGER.log(DEBUG, String.format("[%s] Unable to return client connection because queue is full %s",
199+
conn.channelId(),
200+
Thread.currentThread().getName()));
201201
}
202202
}
203203
} catch (InterruptedException e) {
204204
if (LOGGER.isLoggable(DEBUG)) {
205-
LOGGER.log(DEBUG, "[%s] Unable to return client connection due to '%s' %s",
206-
conn.channelId(),
207-
e.getMessage(),
208-
Thread.currentThread().getName());
205+
LOGGER.log(DEBUG, String.format("[%s] Unable to return client connection due to '%s' %s",
206+
conn.channelId(),
207+
e.getMessage(),
208+
Thread.currentThread().getName()));
209209
}
210210
}
211211
}

0 commit comments

Comments
 (0)