Skip to content

Commit 218da97

Browse files
committed
4.x Make OciMetricsDataTest.beforeEach public
1 parent ac711c9 commit 218da97

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

integrations/oci/metrics/metrics/src/test/java/io/helidon/integrations/oci/metrics/OciMetricsDataTest.java

+6-14
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,9 @@
3232
import io.helidon.metrics.Registry;
3333
import io.helidon.metrics.api.RegistryFactory;
3434

35-
import org.eclipse.microprofile.metrics.MetricRegistry.Type;
36-
3735
import com.oracle.bmc.monitoring.model.MetricDataDetails;
3836

39-
public class OciMetricsDataTest {
37+
class OciMetricsDataTest {
4038
private final OciMetricsSupport.NameFormatter nameFormatter = new OciMetricsSupport.NameFormatter() { };
4139
private final String[] types = {Registry.BASE_SCOPE, Registry.VENDOR_SCOPE, Registry.APPLICATION_SCOPE};
4240
private final String dimensionScopeName = "scope";
@@ -47,21 +45,15 @@ public class OciMetricsDataTest {
4745
private final MetricRegistry appMetricRegistry = rf.getRegistry(Registry.APPLICATION_SCOPE);
4846

4947
@BeforeEach
50-
private void beforeEach() {
51-
// clear all registry
48+
void clearAllRegistry() {
5249
for (String type: types) {
5350
MetricRegistry metricRegistry = rf.getRegistry(type);
54-
metricRegistry.removeMatching(new MetricFilter() {
55-
@Override
56-
public boolean matches(MetricID metricID, Metric metric) {
57-
return true;
58-
}
59-
});
51+
metricRegistry.removeMatching(MetricFilter.ALL);
6052
}
6153
}
6254

6355
@Test
64-
public void testMetricRegistries() {
56+
void testMetricRegistries() {
6557
String counterName = "DummyCounter";
6658
String timerName = "DummyTimer";
6759

@@ -91,7 +83,7 @@ public void testMetricRegistries() {
9183
}
9284

9385
@Test
94-
public void testOciMonitoringParameters() {
86+
void testOciMonitoringParameters() {
9587
String compartmentId = "dummy.compartmentId";
9688
String namespace = "dummy-namespace";
9789
String resourceGroup = "dummy_resourceGroup";
@@ -109,7 +101,7 @@ public void testOciMonitoringParameters() {
109101
}
110102

111103
@Test
112-
public void testDimensions() {
104+
void testDimensions() {
113105
String dummyTagName = "DummyTag";
114106
String dummyTagValue = "DummyValue";
115107

0 commit comments

Comments
 (0)