Fixes webcompat#1412: Add page titles and test for issue page title

heatherbooker · heatherbooker · commit 4a690728f5ac · 2017-03-09T16:18:40.000-08:00
diff --git a/tests/functional/issues-non-auth.js b/tests/functional/issues-non-auth.js
@@ -101,6 +101,15 @@ define([
           assert.notInclude(className, "wc-Comment-content-nsfw--display");
         })
         .end();
+    },
+
+    "Issue page title matches actual issue number": function() {
+      var issueNumber = '100';
+      return FunctionalHelpers.openPage(this, url("/issues/" + issueNumber), ".js-Issue")
+        .getPageTitle()
+        .then(function(title) {
+          assert.include(title, "Issue #" + issueNumber + " | webcompat.com");
+        });
     }
   });
 });
diff --git a/webcompat/templates/about.html b/webcompat/templates/about.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}About | {% endblock %}
 {% block body %}
 {% include "shared/nav.html" %}
   <main class="wc-UIContent" role="main">
diff --git a/webcompat/templates/contributors.html b/webcompat/templates/contributors.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}Contributors | {% endblock %}
 {% block body %}
 <div>
 {% include "shared/nav.html" %}
diff --git a/webcompat/templates/cssfixme.html b/webcompat/templates/cssfixme.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}CSS Fix Me | {% endblock %}
 {% block body %}
 {% include "shared/nav.html" %}
   <main class="wc-UIContent" role="main">
diff --git a/webcompat/templates/issue.html b/webcompat/templates/issue.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}Issue #{{ number }} | {% endblock %}
 {% block body %}
   {% include "shared/nav.html" %}
   <main class="wc-UISection wc-UISection--backgroundColor" role="main">
diff --git a/webcompat/templates/layout.html b/webcompat/templates/layout.html
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
 <head>
-  <title>webcompat.com</title>
+  <title>{% block title %}{% endblock %}webcompat.com</title>
   <meta charset="utf-8">
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <meta name="description" content="Open source community for web compatibility.  Report bugs from websites or for browsers and help us move the web forward.">
diff --git a/webcompat/templates/list-issue.html b/webcompat/templates/list-issue.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}Issues | {% endblock %}
 {% block body %}
 <div class="wc-SearchIssue js-SearchIssue" data-username="{{ session.username }}">
   {% include "shared/nav.html" %}
diff --git a/webcompat/templates/new-issue.html b/webcompat/templates/new-issue.html
@@ -1,4 +1,5 @@
 {%- extends "layout.html" -%}
+{% block title %}New Issue | {% endblock %}
 {%- block body -%}
 {% include "topbar.html" %}
 <main role="main">
diff --git a/webcompat/templates/privacy.html b/webcompat/templates/privacy.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}Privacy Policy | {% endblock %}
 {% block body %}
 {% include "shared/nav.html" %}
   <main class="wc-UIContent" role="main">
diff --git a/webcompat/templates/user-activity.html b/webcompat/templates/user-activity.html
@@ -1,4 +1,5 @@
 {% extends "layout.html" %}
+{% block title %}{{user}}'s Activity | {% endblock %}
 {% block body %}
 {% include "shared/nav.html" %}
 <main role="main">

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}About \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`{% include "shared/nav.html" %}`
`4`	`5`	`<main class="wc-UIContent" role="main">`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}Contributors \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`<div>`
`4`	`5`	`{% include "shared/nav.html" %}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}CSS Fix Me \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`{% include "shared/nav.html" %}`
`4`	`5`	`<main class="wc-UIContent" role="main">`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}Issue #{{ number }} \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`{% include "shared/nav.html" %}`
`4`	`5`	`<main class="wc-UISection wc-UISection--backgroundColor" role="main">`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}Issues \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`<div class="wc-SearchIssue js-SearchIssue" data-username="{{ session.username }}">`
`4`	`5`	`{% include "shared/nav.html" %}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{%- extends "layout.html" -%}`
	`2`	`+{% block title %}New Issue \| {% endblock %}`
`2`	`3`	`{%- block body -%}`
`3`	`4`	`{% include "topbar.html" %}`
`4`	`5`	`<main role="main">`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}Privacy Policy \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`{% include "shared/nav.html" %}`
`4`	`5`	`<main class="wc-UIContent" role="main">`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{% extends "layout.html" %}`
	`2`	`+{% block title %}{{user}}'s Activity \| {% endblock %}`
`2`	`3`	`{% block body %}`
`3`	`4`	`{% include "shared/nav.html" %}`
`4`	`5`	`<main role="main">`