-
Notifications
You must be signed in to change notification settings - Fork 0
fix(styles): Add ESLint config and improve GoogleSafeBrowsing tests #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduce a new ESLint configuration with plugins for enhanced code quality, while removing .codacy.yml. The test for GoogleSafeBrowsing was improved by awaiting expectations for better async handling. Updated the GitHub workflow to trigger only on pull requests and added necessary dependencies to pnpm-lock.yaml.
Reviewer's Guide by SourceryThis PR introduces ESLint configuration with TypeScript support and improves code quality through various changes. The implementation adds a new ESLint config file with perfectionist plugin for enforcing consistent code style, removes Codacy configuration, and enhances test reliability by properly handling async expectations. Class diagram for updated ThreatType, PlatformType, and ThreatEntryTypeclassDiagram
class ThreatType {
+MALWARE
+POTENTIALLY_HARMFUL_APPLICATION
+SOCIAL_ENGINEERING
+THREAT_TYPE_UNSPECIFIED
+UNWANTED_SOFTWARE
}
class PlatformType {
+ALL_PLATFORMS
+ANDROID
+ANY_PLATFORM
+CHROME
+IOS
+LINUX
+OSX
+PLATFORM_TYPE_UNSPECIFIED
+WINDOWS
}
class ThreatEntryType {
+EXECUTABLE
+THREAT_ENTRY_TYPE_UNSPECIFIED
+URL
}
class ThreatEntry {
+hash: string
+url: string
}
Class diagram for ESLint configurationclassDiagram
class ESLintConfig {
+plugins: string[]
+rules: object
+files: string[]
+ignores: string[]
}
class Plugin {
+name: string
}
class Rule {
+name: string
+severity: string
}
ESLintConfig --> Plugin : uses
ESLintConfig --> Rule : enforces
Plugin <|-- Perfectionist
Plugin <|-- Vitest
Rule <|-- SortImports
Rule <|-- SortNamedImports
Rule <|-- SortExports
Rule <|-- SortNamedExports
Rule <|-- SortJSXProps
Rule <|-- SortUnionTypes
note for ESLintConfig "This configuration includes TypeScript support and specific rules for code style."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hckhanh - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Introduce a new ESLint configuration with plugins for enhanced code quality, while removing .codacy.yml. The test for GoogleSafeBrowsing was improved by awaiting expectations for better async handling. Updated the GitHub workflow to trigger only on pull requests and added necessary dependencies to pnpm-lock.yaml.
Summary by Sourcery
Add ESLint configuration with plugins to improve code quality, update GoogleSafeBrowsing tests for better async handling, and modify GitHub workflow to trigger on pull requests only. Remove .codacy.yml and update pnpm-lock.yaml with necessary dependencies.
Bug Fixes:
Enhancements:
CI:
Tests:
Chores: