Skip to content

HLS does not send workspace/configuration on startup #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelpj opened this issue Mar 7, 2022 · 1 comment
Closed

HLS does not send workspace/configuration on startup #2762

michaelpj opened this issue Mar 7, 2022 · 1 comment
Labels
type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@michaelpj
Copy link
Collaborator

It looks like we entirely rely on the client sending us workspace/didChangeConfiguration notifications. This is apparently not what you're supposed to do: you're supposed to pull configuration actively and only rely on the client notifications for updates.

lsp-haskell actually has workaround code for this, possibly this means we behave badly in other clients also.
@michaelpj michaelpj added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage labels Mar 7, 2022
@fwcd fwcd mentioned this issue Sep 13, 2022
Open
@michaelpj
Copy link
Collaborator Author

This got fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelpj @kokobd