google_cloudbuild_trigger resource should not force destroy and then create replacement

[hden]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment
• If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.8

• provider.google v1.19.1

Affected Resource(s)

• google_cloudbuild_trigger

Terraform Configuration Files

resource "google_cloudbuild_trigger" "ds_stream" {
  project     = "toreta-sandbox"
  description = "ds-stream2"

  trigger_template {
    tag_name  = "v.*"
    repo_name = "github-toreta-ds-stream"
  }

  filename = "cloudbuild.yaml"
}

Debug Output

https://gist.github.com/hden/0958315c9ecf4caecf0d41f7addd50e9

Expected Behavior

Terraform should not force destroy and then create replacement for the resource.

Actual Behavior

Terraform will perform the following actions:

-/+ google_cloudbuild_trigger.ds_stream (new resource required)
      id:                           "d6ff659e-7ace-4f27-99dd-48316a88319d" => <computed> (forces new resource)
      description:                  "ds-stream2" => "ds-stream2"
      filename:                     "cloudbuild.yaml" => "cloudbuild.yaml"
      project:                      "toreta-sandbox" => "toreta-sandbox"
      trigger_template.#:           "1" => "1"
      trigger_template.0.project:   "toreta-sandbox" => "" (forces new resource)
      trigger_template.0.repo_name: "github-toreta-ds-stream" => "github-toreta-ds-stream"
      trigger_template.0.tag_name:  "v.*" => "v.*"


Plan: 1 to add, 0 to change, 1 to destroy.

Steps to Reproduce

1. terraform init
2. terraform apply
3. terraform plan (note that although nothing has changed, terraform is suggesting a destroy and re-create operation)

[danawillow]

Partially fixed in #2121, working on a full fix now.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!