Skip to content

Commit 3bdecaa

Browse files
committed
chore: deprecated ssh_skip_request_pty
Deprecated `ssh_skip_request_pty` per comment: ``` // These are deprecated, but we keep them around for BC // TODO(@mitchellh): remove" ``` Signed-off-by: Ryan Johnson <[email protected]>
1 parent 330dc55 commit 3bdecaa

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

builder/vmware/common/ssh_config.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,22 @@
66
package common
77

88
import (
9+
"log"
10+
911
"github.com/hashicorp/packer-plugin-sdk/communicator"
1012
"github.com/hashicorp/packer-plugin-sdk/template/interpolate"
1113
)
1214

1315
type SSHConfig struct {
1416
Comm communicator.Config `mapstructure:",squash"`
1517

16-
// These are deprecated, but we keep them around for BC
17-
// TODO(@mitchellh): remove
18+
// TODO: Deprecated. Remove in next major release
1819
SSHSkipRequestPty bool `mapstructure:"ssh_skip_request_pty"`
1920
}
2021

2122
func (c *SSHConfig) Prepare(ctx *interpolate.Context) []error {
2223
if c.SSHSkipRequestPty {
23-
c.Comm.SSHPty = false
24+
log.Printf("[WARN] 'ssh_skip_request_pty' is deprecated and will be removed in the next major release.")
2425
}
2526

2627
return c.Comm.Prepare(ctx)

builder/vmware/iso/config.hcl2spec.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

builder/vmware/vmx/config.hcl2spec.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)